Failed emoji unicode -> image conversion

סיכום מבוסס בינה מלאכותית

A discussion on the failed conversion of emoji unicode to images was initiated by Falco. The issue is that certain unicode characters, such as 0️⃣1️⃣2️⃣3️⃣4️⃣5️⃣, are not being replaced with their corresponding emoji images, like :zero: :one: :two: :three: :four: :five:. codinghorror confirmed the issue, and joffreyjaffeux discovered that it was due to an old decision made by eviltrout. The reason for this decision is unclear, but eviltrout suggested removing it to see the outcome. A pull request to fix the issue has been created by joffreyjaffeux.

Continuing the discussion from Ratings instead of Hearts for Likes:

Why this didn’t become this:

?

4 לייקים

:zero: hmm let’s see :one:

Yeah that is odd, any thoughts @j.jaffeux

3 לייקים

Turns out that’s an old decision from @eviltrout discourse/app/models/emoji.rb at main · discourse/discourse · GitHub

Not sure about the reasons?

So :one: will work but :one: won’t get replaced.

5 לייקים

I don’t remember the exact reason (this is why I am now bullish on more detailed commit messages) but I suspect that a lot of symbols were being converted that we didn’t want to. I wouldn’t mind removing it to see what happens. Maybe we can re-learn the reason :slight_smile:

6 לייקים

That should fix it:

https://github.com/discourse/discourse/pull/7978

4 לייקים