Muting topics does not stick

AI-generated summary

In a bug report titled “Muting topics does not stick,” Wingtip reported that topic muting was broken in Discourse 2.4.0.beta11 — muting appeared to work initially but disappeared after page refresh, causing muted topics to reappear in the Latest view. j.jaffeux confirmed the issue, noting it occurred only when muting from the timeline (not from within a topic), and quickly identified and fixed the bug. The fix was submitted via PR #9021, which also added tests to prevent future regressions. After the fix was merged and passed tests, Wingtip requested a heads-up for deployment, as users were complaining. j.jaffeux confirmed the merge and offered further assistance if needed. Wingtip later confirmed the fix was working and thanked the developer. The issue was resolved swiftly through collaboration, with j.jaffeux appreciating the update.

We’re running 2.4.0.beta11 (cf0c6d5761). Topic muting is completely broken for us.

When I mute a topic in a category that is not muted:

It appears to work:

But then when I refresh the page with F5, the mute is gone, and it still shows up in the Latest view.

Is this a known bug? We haven’t changed our configuration recently, although we do update fairly regularly and are on the very latest version as of today.

5 Likes

Yes I can repro. It’s very unexpected. It seems to happen only on muted from the timeline, muted from under a topic seems to work, and other actions work. It’s the same component. Digging, will probably have a fix shortly.

6 Likes

Fantastic! Thanks Joffrey as always.

1 Like

Ok, fixed, good catch, thanks!

https://github.com/discourse/discourse/pull/9021

This should fix it and add more tests to prevent future regression on this topic timeline button.

Waiting for tests and will merge it.

11 Likes

Thanks, appreciate if you could give a heads-up when it’s merged so we can update, had a bunch of users complaining about this.

4 Likes

This is merged and in tests-passed.

Let me know how it goes for you, I’m online few more hours and can fix more if needed.

5 Likes

Confirmed fixed. Thanks again!

6 Likes

Great thx for update

6 Likes