The discussion revolves around issues with WebHookEventType in the context of the solved and assign plugins. RGJ reports that after a change moving webhook event type seeding to core, two problems arise: (1) event types appear without translations or functionality on instances without the plugins, and (2) the plugins are broken on new stable and beta installs due to missing seeds. Blake acknowledges the first issue and provides a fix, while clarifying that the second issue—where the webhook type doesn’t appear on new installs—is intentional, as it’s a 2.5+ feature. RGJ confirms the behavior and clarifies that ‘broken’ was misleading, and Blake agrees. RGJ expresses a preference for keeping seeding logic within the plugins rather than core, though acknowledges it’s a matter of opinion.
on instances that do not have the solved or assign plugins installed, the event types are showing but the translation is missing, and (of course) the events are not available although they are being shown.
the solved and assign plugins are currently broken on new stable and beta installs because they are missing the seeds
My initial thought was to ask you to backport the seeds to stable to fix #2, but since there is an additional bug (#1) maybe it is better to leave the seeding code in the actual plugin and just reserve the ID’s in the code in core.
Long story short, I think it would be better to move the
WebHookEventType.seed do |b|
b.id = WebHookEventType::SOLVED
b.name = "solved"
end
A new install on stable with the latest version of the solved plugin will not have the ID’s in the web_hook_event_type table, preventing the webhook type from showing.
This is happening because the code that seeds the ID’s has been removed from the solved plugin and it is not yet present in the stable / beta release.
Previously installed sites that had an older version of the solved plugin will already have the seed data and they will not have the problem.
So replication step is easy: create a brand new install on stable.
Clean new install on 2.4.1 with solved plugin: no webhook available.
Ok, you are completely right, my apologies for being unclear. I was mixing up ‘broken’ and ‘not available’, and since this is a new feature there is indeed nothing broken.
It does feel a bit strange how seeding code for a plugin is moved into core though. I can understand that you want to reserve the ID’s but I think it would be more clean to leave the seeding in the plugin. But that’s just my own personal opinion