Screen goes dim when pressing bottom ๐Ÿ”ง

ืกื™ื›ื•ื ืžื‘ื•ืกืก ื‘ื™ื ื” ืžืœืื›ื•ืชื™ืช

A user, ondrej, reported an issue with the screen going dim when pressing the bottom wrench in landscape mode. A video was provided to demonstrate the issue. jomaxro asked if the issue could be reproduced in safe mode, which ondrej confirmed. However, ondrej found that the dimness disappeared and the screen worked when pressing, dragging, and releasing. awesomerobot recognized the issue and suspected a media query problem with large phones in landscape. A fix was later provided by awesomerobot in a GitHub commit, which ondrej successfully implemented.

Continuing the discussion from Topic :wrench: menu cut off in landscape (admin): Firstly thanks awesomerobot for the fix! I found that if you turn screen landscape and press the bottom wrench the screen goes dim and you cannot press any actions. Not sure if this relates to other topic as it happened before the fix. Video below:

Thanks

ืœื™ื™ืง 1

Can you reproduce in safe mode? Iโ€™m curious if it is theme related. No repro here on Meta with the default light or dark theme.

ืœื™ื™ืง 1

Hello, yes I could repro in safe mode. However the only difference is that if I hold (press), drag screen and release dimness disappears and it works. :thinking:

ืœื™ื™ืง 1

I can see this issue, looks like itโ€™s been around before the other fixโ€ฆ guessing thereโ€™s just a media query thatโ€™s not quite wide enough to account for large phones in landscape. Will take a closer look.

4 ืœื™ื™ืงื™ื

Annnd I thought I would report it now :neutral_face:. I could have saved you a job. However, thanks for looking into it!

ืœื™ื™ืง 1

This fixes it, we were only accounting for vertical layouts on mobile

https://github.com/discourse/discourse/commit/94d10b46cad862116cf956e68fa9e1ee9985f067

5 ืœื™ื™ืงื™ื

OK updating now. Thanks so much :blush:

2 ืœื™ื™ืงื™ื

This topic was automatically closed after 6 hours. New replies are no longer allowed.