Hiding post history from Trust level 4

AI-generated summary

The discussion revolves around a bug where Trust Level 4 users can still view post revision history despite the site setting being disabled, which is supposed to restrict this access to staff only. jughead reports the issue, noting that while the setting claims only staff can view history, Trust Level 4 users (who are not staff) can still see it. ondrej suggests manually hiding revisions, but jughead emphasizes the need for a permanent fix. codinghorror identifies this as a potential bug, and zogstrip directs it to the development team. nbianca confirms the fix has been implemented, ensuring only staff can view edit history when the setting is off. jughead thanks the team for the resolution.

Hi!

For some reason when this setting is disabled it still shows editing history for Trust level 4.

How can I prevent Trust level 4 from seeing anyone else’s revision history? If it easier to just disable it so own edit history can’t be viewed either, that’s fine too.*

Edit: Trust level 3 and below can’t view history. The setting explicitly mentions only staff members can view history, Trust level 4 are not members of staff.

AFAIK Trust level 4 are not members of the staff group, at least they are not listed as such in my forum. So they shouldn’t be able to view any editing history?

Hi

What if you just press ‘Hide revision’ button on a edited post?

That works and hides it for Trust level 4. It shouldn’t show to Trust level 4 users in the first place.

So do that.

I find it useful as they are still effectively moderating the site so its a good tool they can see edits in my opinion.

The problem is it shouldn’t show revision / edit history to Trust level 4 as the option is disabled. It isn’t feasible for me to start hiding revision history manually, I need to have it set up this way.

This does feel like a minor bug @zogstrip .. it says “only staff members” so maybe we are missing some logic in this check? :thinking:

Thanks for looking into it! Looking forward to a fix. :smiley:

@nbianca can you add that to your list?

Looking like I was taking advantage of a bug :joy:

Perhaps a trust level setting “minimum trust level required to see editing history” should be added as a extra to allow for what @ondrej has been using exactly.

Same, if this is changing there are a few TL4 users that I will (unfortunately) need to promote to moderators.

No, I don’t support a site setting here. It should match the behavior as described.

Now, when edit history visible to public site setting is disabled, only staff can see the previous versions of an edited post.

https://github.com/discourse/discourse/pull/10065

Thanks a lot for fixing this Bianca! :smiley: