GitHub Plugin: Support for Issues

סיכום מבוסס בינה מלאכותית

The discussion centers around adding GitHub issue linkback support to the Discourse GitHub plugin. robbiet480 highlights a recent PR enabling GitHub API badges and asks if a PR for issue linkbacks would be accepted, noting their team at Home Assistant relies on GitHub issues. sam is open to the idea if it’s opt-in and requests a mock showing how it would appear on GitHub and what site settings would be involved. robbiet480 proposes the linkback comment would mirror the PR format and suggests a single setting: “github linkback on issues enabled” with a checkbox. New user Caleb_Hailey and RCheesley express strong support for the feature. sam reiterates openness to a PR but emphasizes security concerns, recommending use of a throwaway GitHub account token with no repo access, similar to Discourse’s code review implementation. The community clearly sees value in extending linkback functionality to GitHub issues, pending a secure, well-documented implementation.

Glad to see a PR recently added to use the GitHub API for badges thanks to @Osama.

I know that previously @codinghorror has said that issue linkback support won’t be added as Discourse doesn’t use GitHub issues but we at Home Assistant do with no plans to migrate away from GitHub issues anytime soon (no matter how much we love Discourse!). Would a PR be accepted if I submitted one to enable linkbacks for issues too? I’d be more than happy to make it opt in via a setting.

3 לייקים

I am not against adding this as a default off option, but first i want to see a mock of how this would work.

  1. How will it look on GitHub?

  2. What site settings are you talking about adding.

2 לייקים
  1. I think it would look exactly the same as it does on a PR. Just a comment on the issue with the same text (This issue has been mentioned on Discourse Meta. There might be relevant details there.\n\n\<link>). Maybe you are thinking of a reason that you may think that text would need to change as it’s extremely likely I am not thinking all reasons through.

  2. I’d say just one setting titled “github linkback on issues enabled” with a checkbox.

3 לייקים

Hi there :wave: first post on the discourse meta discourse… thanks for making a wonderful product!

I’m just here to offer my :+1: for GitHub Issue linkbacks. This would be huge for my team!

4 לייקים

Just adding my voice, would love to see this functionality to have the same kind of behaviour with Github Issues as with commits and PR’s.

2 לייקים

I am open to a PR that adds support for something here, getting security right is tricky, we have done something in discourse code review but you need a token and you don’t want it to be your token, instead one of a throwaway github account that has no access to repos you care about.

3 לייקים

A post was split to a new topic: Add support for issues to the discourse code review plugin