Full screen tables not showing in 2.8.0.beta8

AI-generated summary

User mcdanlj reported that the new “Expand Table” button in Discourse 2.8.0.beta8 wasn’t appearing on their forum, despite trying browser refreshes and resizing. After further testing, including a shift-click reload, the feature eventually appeared, suggesting a delay in post rebaking was the cause. JammyDodger confirmed the button was visible on the same page using Chrome on Android. mcdanlj attempted a console script to rebake only posts containing <div class="md-table">, but it didn’t immediately resolve the issue, indicating rebaking may take longer than expected. Eventually, the feature worked after more patience, as noted in post 5. sam suggested checking if table size thresholds affect visibility, but since the issue resolved itself, sam closed the topic, thanking mcdanlj for their patience. The takeaway: full-screen table functionality requires posts to be rebaked after upgrading, and the process may not be instant.

I really like the idea of the full screen table feature just announced:

I just deployed 2.8.0.beta8 (32c6c4f417) and can’t see any Expand Table button on a table, on either or Firefox or Chrome. I rebuilt HTML in case that was a requirement, and it still didn’t help. I resized the browser window small and large to see if that mattered, and couldn’t make it show up.

The table I was trying to view as an example was here:

Do I misunderstand something about this feature? I’d like to announce it to my community, but want to make sure it works first. :smiling_face:

I can see the Expand table button on the example link?

(let me know if the picture is not okay to share :+1:)

I’m currently using Android, Chrome.

2 Likes

Thank you! Picture fine to share and appreciated.

I checked that the windows from reporting the problem before still didn’t work just now, including when I did a reload, but after a shift-click reload (yet again; I had done that this morning before asking this) it now shows up for me in both Firefox and Chrome.

I’m guessing that it actually took a rebake, and that the rebake took longer than I expected.

I have confirmed that another page which I have not rebuilt still does not show the feature, even on a shift-click reload, so it must be that tables have to be rebaked for this to work.

I wonder if there is a console way to rebake only all tables. Maybe rebaking all posts where <div class="md-table"> is in cooked…

posts = Post.where("cooked like '%<div class=\"md-table\">%'")
posts.each do |p|
   p.rebake!
end  

That doesn’t seem to have resolve the problem, though. I watched sidekiq drain all the rebuilds so it definitely kicked off the rebakes.

1 Like

I think there are some thresholds in place, can you paste the table in to this topic, does the button show up?

1 Like

Actually, it eventually worked. I was again too impatient. :smiling_face:

2 Likes

Cool, no worries, closing this off. Thanks for :bear:ing with us ;p

2 Likes