Inconsistent micro-edit button behavior

renato · June 23, 2023, 1:39pm

This is where this is currently defined:

app/assets/javascripts/discourse/app/components/quote-button.js

6d9568a9a


      
          if (this.siteSettings.enable_fast_edit) {
            this.set(
              "_canEditPost",
              this.topic.postStream.findLoadedPost(postId)?.can_edit
            );
          
            if (this._canEditPost) {
              const regexp = new RegExp(escapeRegExp(quoteState.buffer), "gi");
              const matches = cooked.innerHTML.match(regexp);
              const non_ascii_regex = /[^\x00-\x7F]/;
          
              if (
                quoteState.buffer.length < 1 ||
                quoteState.buffer.includes("|") || // tables are too complex
                quoteState.buffer.match(/\n/g) || // linebreaks are too complex
                matches?.length > 1 || // duplicates are too complex
                non_ascii_regex.test(quoteState.buffer) // non-ascii chars break fast-edit
              ) {
                this.set("_isFastEditable", false);
                this.set("_fastEditInitialSelection", null);

This file has been truncated. show original

I believe that in your test you hit the “duplicates are too complex” condition, like Michael said. It also uses the full editor if tables, line breaks or non-ascii characters are involved.

Topic		Replies	Views
Add keyboard shortcuts to Fast Edit UX completed , fast-edit , keyboard-shortcuts	6	561	October 11, 2021
What action (user or back-end) controls the mini edit pane Product Support	2	647	March 29, 2022
Why does fast edit often open the composer instead? Product Support fast-edit	1	359	September 1, 2023
Introducing fast edit Announcements new-feature , fast-edit	0	5748	September 22, 2021
Fast edit doesn't work on content with certain characters Bug fast-edit	17	1529	May 11, 2023

Inconsistent micro-edit button behavior

Related topics