Plugin name is 'discourse-topic-voting', but plugin directory is named 'discourse-voting'

Contribute UX

AI-generated summary

A warning occurs when rebuilding Discourse due to a mismatch between the plugin name discourse-topic-voting and its directory name discourse-voting or discourse-feature-voting. Firepup650 initially reported the issue, which Benjamin_D acknowledged as a pending task.

balupton shared a solution, involving updating the configuration to point to the correct repository URL (https://github.com/discourse/discourse-topic-voting). However, Firepup650 noted that their warning message differed from balupton’s.

JammyDodger explained that the plugin has undergone name changes and that the older name in the app.yml file shouldn’t cause issues due to a redirect. They agreed with balupton that improving the warning message would be beneficial, suggesting a more informative message to prompt users to update their configuration.

1

Finally remembered to post here about it, discourse-topic-voting’s directory doesn’t match it’s name, which throws a warning when rebuilding.
Plugin name is 'discourse-topic-voting', but plugin directory is named 'discourse-voting'

4 Likes
2

thank you! meant to do the same for ages :sweat_smile:

1 Like
3

Is that more than just a cosmetic thing? Asking it only because there is another plugins too — or was, because it was a while ago when I had enough energy to follow feed of rebuilding :woozy_face:

1 Like
4

I got the warning:

Plugin name is ‘discourse-topic-voting’, but plugin directory is named ‘discourse-feature-voting’

Which is a confusing message.. it doesn’t state clearly what is the required action, adn which value is correct.

With some investigation, what I had to do was change:

- git clone https://github.com/discourse/discourse-feature-voting.git

to

- git clone https://github.com/discourse/discourse-topic-voting.git

Would be better if that message was:

Your configuration lists the plugin discourse-feature-voting however it has been renamed to discourse-topic-voting. You should update your configuration.

1 Like
5

Interesting, but that seems to be a slightly different warning message (warning I see just lists “discourse-voting”)

6

I think it may have had a few name changes over the course of its life. Having the older name in your app.yml shouldn’t cause any actual issue as I think there’s a redirect, but if you add the current link in there that should sort it out:

https://github.com/discourse/discourse-topic-voting

Though I think this change does make sense:

1 Like