Reactions page glitches view when attempting to fetch more posts where no more posts exist

AI-generated summary

The Reactions page on a user’s profile is experiencing glitches when attempting to fetch more posts, even when there are no more posts. This issue is observed when the Reactions plugin is enabled. simon_tomes shared a screenshot of the issue and noted that it occurs when scrolling down to the bottom of the page.

Moin reported that the issue only occurs when checking someone else’s reactions, not one’s own. The glitch causes the page to jump up and down, and it has been observed in Chrome and Edge browsers, but not in Firefox.

In addition to the glitch, there is also an issue with access denied when trying to view someone else’s reactions. However, this issue has been fixed with a recent commit (davidb).

The glitch issue has also been fixed with another commit (davidb), which should resolve the repeated requests and page jumpiness issue.

With the reactions plugin turned on.

  1. Find a user who has had a few reactions to their posts
  2. Visit the reactions page on a user’s profile: /activity/reactions
  3. Scroll down to the bottom

The page attempts to fetch more posts and a spinner glitches the page up and down.

I’ve not shared a video as it would reveal user info, so hopefully this screenshot with the pending requests is good enough.

Thanks for investigating.

I got something different here on Meta checking your reactions:


https://meta.discourse.org/u/simon_tomes/activity/reactions

2 Likes

Noticed that too. It works to check your own, but not anyone else’s reactions.

@Firepup650 Ah yes, of course I can check on here. :facepalm:

I’ve checked my own Activity > Reactions and I see the glitch.

1 Like

I can ditto for mine, I suppose we need two separate reports on that page now, lol. (Shakes for the account owner, and is denied to others)

1 Like

I can repro the ‘Access Denied’ issue when using a non-admin/anon account.

I’m not seeing the same glitch for the bouncing page. I do get a small one, but not as much as the video. Is this because of the browser? (I tried with Firefox)

4 Likes

Yes. Firefox is fine, Chrome and Edge are not

3 Likes

I experienced the issue using Chrome Version 120.0.6099.234 on macOS Sonoma.

1 Like

The access-denied issue appears to be a regression from a recent change, it should now be fixed with this commit:

https://github.com/discourse/discourse-reactions/commit/69b1fd45a43333508a37684d11924c3fadc8d2dd

Logged in users should be able to see the reactions given by users from the Activity tab on the user profile again.

The other issue of repeated requests and page jumpiness still needs further investigating.

4 Likes

This should be fixed with this commit:

https://github.com/discourse/discourse-reactions/commit/e1f9cc835f257718735efa1113484f0985b0f27c

2 Likes

This topic was automatically closed after 2 days. New replies are no longer allowed.