An error occurred at login modal (same as topic 293167)

hellekin · February 1, 2024, 12:38am

I have noticed this bug before on Meta, but then it appeared on my deployments after the latest upgrade: when clicking login, the “Welcome back ” modal appears, and is immediately shadowed by “Sorry, an error occurred”. Clicking OK removes the error modal and you can resume authentication normally.

There’s an error log in the console:

ajax-error.js:9:12
    l ajax-error.js:9
    p ajax-error.js:95
    passkeyLogin login.js:147

Moin · February 1, 2024, 12:38am

Which browser do you use?

hellekin · February 1, 2024, 12:40am

Firefox 115.7.0esr (64-bit) on Debian 12.

Discourse v3.3.0.beta1-dev — Commits · discourse/discourse · GitHub — Ember v5.5.0

Moin · February 1, 2024, 12:41am

Then I think it is the same issue as Error message displaying at login with Linux/Firefox

Arkshine · February 1, 2024, 1:17am

This is a regression introduced here: FEATURE: Allow users to confirm session with passkeys (#24337) · discourse/discourse@c6ead3f · GitHub

github.com/discourse/discourse

app/assets/javascripts/discourse/app/lib/webauthn.js

c6ead3f5c


      
          ) {
            if (!isWebauthnSupported()) {
              return errorCallback(I18n.t("login.security_key_support_missing_error"));
            }
          
            // we need to check isConditionalMediationAvailable for Firefox
            // without it, Firefox will throw console errors
            // We cannot do a general check because iOS Safari and Chrome in Selenium quietly support the feature
            // but they do not support the PublicKeyCredential.isConditionalMediationAvailable() method
            if (mediation === "conditional" && isFirefox) {
              const isCMA = await PublicKeyCredential.isConditionalMediationAvailable();
              if (!isCMA) {
                return;
              }
            }
          
            try {
              const resp = await ajax("/session/passkey/challenge.json");
          
              const credential = await navigator.credentials.get({
                publicKey: {

I think the code needs to be moved in the try{} below; otherwise, the error will use the UI instead of the console.

github.com/discourse/discourse

app/assets/javascripts/discourse/app/lib/webauthn.js

c6ead3f5c


      
              userHandle: bufferToBase64(credential.response.userHandle),
            };
          } catch (error) {
            if (error.name === "AbortError") {
              // no need to show an error when the cancelling a pending ceremony
              // this happens when switching from the conditional method (username input autofill)
              // to the optional method (login button) or vice versa
              return null;
            }
          
            if (mediation === "conditional") {
              // The conditional method gets triggered in the background
              // it's not helpful to show errors for it in the UI
              // eslint-disable-next-line no-console
              console.error(error);
              return null;
            }
          
            if (error.name === "NotAllowedError") {
              return errorCallback(I18n.t("login.security_key_not_allowed_error"));
            } else if (error.name === "SecurityError") {

pmusaraj · February 2, 2024, 9:40pm

Thanks for the report. This should be fixed via FIX: Handle old Firefox versions that do not support isConditionalMed… by pmusaraj · Pull Request #25549 · discourse/discourse · GitHub, I could only repro with that version of Firefox on Windows/macOS, but the fix should apply to other OSs as well.

pmusaraj · February 6, 2024, 10:41pm

This topic was automatically closed after 4 days. New replies are no longer allowed.

Topic		Replies	Views
Runtime error login bug Bug passkey	17	999	October 27, 2023
Login page not working on android app Product Support passkey	6	567	October 27, 2023
Potential minor bug on login with Firefox? (possibly since last update...) Bug passkey	3	386	February 16, 2024
Error message displaying at login with Linux/Firefox Product Support passkey	7	754	April 16, 2024
Passkey login: An error occured: The security key is not owned by the user Bug passkey	2	260	June 4, 2026

An error occurred at login modal (same as topic 293167)

AI-generated summary

Related topics