'Illegal' flag missing translation in Chat

AI-generated summary

A discussion about a missing translation for the “illegal” flag in Chat on the Discourse platform. hello-smile6 initially reported the issue, which was confirmed by Firepup650 and anon36555649. The bug was reported to be present in both the main update branch and stable branch, causing “Translation missing: en_GB.flag_reasons.illegal” or “Translation missing: en.flag_reasons.illegal” to appear in email notifications.

tobiaseigen announced that the bug had been fixed, but ondrej and HAWK reported that the issue still existed. Further testing revealed that the bug was specific to chat message flags and non-US locales. ondrej found that the issue was device-dependent, working on mobile but not on desktop.

tobiaseigen was able to reproduce the issue, and ted provided a fix in a GitHub pull request. However, HamMan2118 reported that the translation was still in English for all languages. joffreyjaffeux explained that the translation would be added over time.

“illegal” chat flags don’t seem to have an English translation, is that intended?

7 Likes

Heh, this flag from admin/mod side seems a bit wrong, lmao:

Is this chat message it’s illegal?

13 Likes

That looks like a bug, is supposed to display:

“This post requires staff attention because I believe it contains content that is illegal.”

This appears in that system dialogue box now when I have tested this, but e-mail notification shows similar to what you see there:

Translation missing: en_GB.flag_reasons.illegal

Contribute > Bug !!

(That is with main update branch not beta or tests-passed)

Same with stable branch for message/e-mail notification:

Translation missing: en.flag_reasons.illegal

That is only sent if response to flag is to hide post and give author option to edit.

4 Likes

The bugs reported by @Firepup650 and @anon36555649 have been fixed. Please update and try it again, and let us know if you still see any issues. Thanks! :sunflower:

10 Likes

This appears to still be the case. :thinking:

2 Likes

Has the forum you tested on been updated recently?

Yes. Plus that is a screenshot from Meta.

Weird – so is this.

So I found twoone conditions for this by experimenting:
1. Non-US locale (UK for example)
2. Specifically, MUST be a chat message flag.

1 Like

My bad, I missed that obvious nuance.

2 Likes

I’ve just done some testing with @HamMan2118 and I’ve found out that it works fine on my mobile but not on my desktop.

Here is my view on mobile

And here is my view on desktop

3 Likes

Thanks! I am able to repro this here on meta. We’ll get this fixed up.

3 Likes

Thanks for the report @hello-smile6. :pray:

We missed out on chat when implementing this. The fix is here:

https://github.com/discourse/discourse/pull/26255

(Note that it’s a client-side translation, so you’ll need to reload the page after deploying to see the fix.)

4 Likes

Thank you for this fix :slight_smile:

However, I noticed that the translation is English in every language. An example below is what it looks like in German, but this is how it looks in every other language.

3 Likes

Es liegt daran, dass es noch nicht ins Deutsche übersetzt wurde, das wird im Laufe der Zeit kommen.

4 Likes

This topic was automatically closed after 2 days. New replies are no longer allowed.