Latest Update - Broken House Ads

[Vaping_Community]

Version: 3.3.0.beta4-dev

UPDATE

Removed all house ads and site is working normally again, see reply to this post for the error given in console

###########################################################

Since I upgraded our site, I have had a list of problems

• Login button on mobile doesn’t work
• Topics are blank
• Users experiencing problems all over including not being able to read messages
• Main menu not working (no simple access to admin)

Errors

Job exception: undefined method `id’ for nil:NilClass 4:52 am

Failed to warm up pretty text: JavaScript was terminated (either by timeout or explicitly) /var/www/discourse/vendor/bundle/ruby/3.2.0/gems/mini_racer-0.9.0/lib/mini_racer.rb:242:in `call_unsafe’ /var 4:55 am

Job exception: undefined method `id’ for nil 5:11 am

I’ve tried rebuilding via SSH but no joy

All help appreciated, thanks

[Vaping_Community]

Found this via console

house-ad.js:104 Uncaught (in promise) 
TypeError: Cannot read properties of undefined (reading 'category_ids')
    at house-ad.js:104:1
    at Array.filter (<anonymous>)
    at house-ad.js:102:1
    at Array.forEach (<anonymous>)
    at e.didInsertElement (house-ad.js:96:1)
    at e.r [as didInsertElement] (index.js:361:1)
    at e._trigger (core_view.js:55:1)
    at e.r (index.js:361:1)
    at e._trigger (ember-events.js:145:1)
    at e.r (index.js:361:1)
    at ze.didCreate (index.js:2102:1)
    at jt.commit (runtime.js:3965:1)
    at Mt.commit (runtime.js:4062:1)
    at Nt (runtime.js:4082:1)
    at gr._renderRoots (index.js:4916:1)
    at gr._renderRootsTransaction (index.js:4960:1)
    at gr._renderRoot (index.js:4905:1)
    at gr._appendDefinition (index.js:4830:1)
    at gr.appendOutletView (index.js:4820:1)
    at invoke (backburner.js.js:282:1)
    at h.flush (backburner.js.js:197:1)
    at p.flush (backburner.js.js:358:1)
    at B._end (backburner.js.js:798:1)
    at B._boundAutorunEnd (backburner.js.js:523:1)

[Vaping_Community]

Resetting House ads (removed and reinstated) fixed this problem

[techAPJ (Arpit Jalan)]

I have a PR up with the fix:

https://github.com/discourse/discourse-adplugin/pull/214

However, I am unable to repro this issue on my dev server. @Vaping_Community do you have repro steps for this issue so that I dig even deeper?

[Vaping_Community]

This is all I can give you, I hope it helps

Note: Between Posts had 6 ads in place

Example of advert

All adverts use the same format

<a class="fcbanner" target="_blank" href="https://vapeview.co/?r=vcuk"><img src="https://vapingcommunity.co.uk/uploads/default/original/3X/2/d/2d2e817cadaadd3e8b5ae638af67f580763848f7.jpeg"/></a>

CSS

.fcbanner img {
    width: 700px;
}

[techAPJ (Arpit Jalan)]

Thanks for the details, but still unable to repro this issue on my dev setup. Anyways, can you try updating the plugin source code and see if everything looks good to you? The PR merged above should fix the issues you were seeing.