Moin
15 Agosto 2024, 9:16am
1
Indipendentemente dal fatto che io faccia clic su “Conferma” o “Revert”, il testo nella finestra di composizione è “SuperTool script” in seguito.
4 Mi Piace
keegan
16 Agosto 2024, 5:45pm
3
Grazie @Moin per averlo individuato! Questo dovrebbe ora essere risolto con:
main ← fix-diff-modal
opened 11:36PM - 15 Aug 24 UTC
In https://github.com/discourse/discourse-ai/pull/715, we refactored the compose… r helper menu to use `DMenu` instead of `popperJS`. Since the `AiComposerHelperMenu` component was an instance of `DMenu`, having modals defined in the component's template directly was likely resulting in various issues. For example, clicking anywhere on the `DiffModal` was closing the modal which led to issues such as [being unable to revert.](https://meta.discourse.org/t/the-revert-button-in-the-changes-popup-does-not-work/321783/2)
In this PR we update the usage of the Diff and Thumbnail Suggestion modals to be instantiated by the modal service using `this.modal.show()` instead of being directly defined in the template. This allows for the modals to work correctly.
3 Mi Piace
keegan
17 Agosto 2024, 3:00pm
5
Questo argomento è stato chiuso automaticamente dopo 21 ore. Non sono più consentite nuove risposte.
