Hi everyone, I’m getting started on developing things for Discourse, and I’m working on a theme component. Link: GitHub - NateDhaliwal/discourse-persistent-banner: A theme component for Discourse that cannot be closed by the user. · GitHub When putting it on Theme Creator, the settings don’t appear, even though I have a settings.yml. Any ideas?

created a quick pull request for you so you can see the way to split up the files properly. feel free to merge or just have a look at the branch. https://github.com/NateDhaliwal/discourse-persistent-banner/pull/3

Do you see any error messages at theme creator? settings.yml main description: "This will change the background color of the banner. Enter valid CSS colours or hex values (including the #)." I think you have to use the same quotation marks at the beginning and end. settings.yml main default: "black" This could also be a problem. I would try default: "" settings.yml main banner_border_thickness: default: 3 type: integer description: "This will change the border thickness of the banner. All numbers are in pixels (px)." banner_text_content: Maybe you want to add “block” to the choices. Otherwise you have to use the revert button to choose that again.

Whoops, just realised I was clicking on ‘Create new’ instead of importing it… But now, when I try using the URL, it says that about.json is invalid or doesn’t exist, asking me if it is a theme. About.json: about.json main { "name": "Persistent banner", "about_url": "https://meta.discourse.org/t/discourse-persistent-banner/330575", "license_url": "https://github.com/NateDhaliwal/discourse-persistent-banner/blob/main/LICENSE", "component": true, "theme_version": "5.0.0", "authors": "NateDhaliwal" } Is there something wrong?

Missing comma after license URL.

:roll_eyes: @merefield Would version be in ""?

Probably that too. Just look at examples.

Thanks! One last one, I can’t seem to get the variable to display. https://github.com/NateDhaliwal/discourse-persistent-banner/blob/main/common/header.html Was it because I didn’t initialise it properly? I tried following the guide…

don’t use “header.html”, use a proper component (preferably a .gjs file, but .hbs might suffice). use html-safe helper whenever outputting html from settings or variables.

Would I have to use import Component from "@glimmer/component"; export default class PracticeComponent extends Component { get bannerLinks() { return JSON.parse(settings.banner_links); } } then?

Look at the billions of examples :stuck_out_tongue_winking_eye:

You only need to use a gjs file if you need to process stuff with javascript, otherwise an hbs template file might suffice. Experiment.

Settings not appearing

Development

merefield (Robert) September 21, 2024, 11:57am 14

You do not need and should not put script tags in hbs files. They should be limited to the content of the template.

Don’t stab in the dark, read the guides:

Topic		Replies	Views
Add support for theme settings Feature	18	5582	May 4, 2018
How are theme setting fields created? Product Support	6	2534	May 8, 2018
Uninitialized variable named settings Development kanban-board	1	185	February 17, 2023
Discourse Persistent banner Theme component	9	734	October 20, 2024
Cannot put the template in the desired outlet Development	12	525	October 14, 2024

Settings not appearing

Related topics