Discourse Persistent banner

Nice work Nate. :clap: :slight_smile:
I like the simplicity

I donโ€™t think the theme creator preview is working. :thinking:

A few suggestions for you to think about:

  • there is a bit of an issue of placement on desktop mode, especially if one is using a wide / full screen.

  • it would be nice to control that border size and color.

  • perhaps options for placement with different plugin outlets, like below-site-header and above-main-containter?

  • while the use of enum list vs text input for color choices is convenient, it also limits admins from using the color pallet variables that work with dark / light modes, or for being more granular with hex color values.

  • I would suggest making the banner string text input setting with the textarea: true property, then you will get a multi-line textbox that the user can expand. Then itโ€™s easier to do this:

2 Likes