Feature request: link to title not body when sharing to discourse PWA

AI-generated summary

This feature request centers on improving how links are shared to the Discourse PWA. Originally, sharing a link would only populate the post body, not the title. merefield initiated the request, questioning the logic behind sharing to the body instead of the title merefield. @Falco attempted to pinpoint the PR that originally introduced the feature but found it difficult to trace Falco. Discussion arose around detecting link-based shares versus textual content [Falco](/t/-/365156/4, merefield. merefield then created a plugin—discourse-share-to-link-oneboxer—to support both text and link shares, with text going to the body, titles to the title, and links to the title with onebox rendering merefield. A pull request PR -32631 was submitted merefield and subsequently merged by @Falco Falco. merefield thanked @Falco for reviewing the PR. merefield has confirmed the update is working, noting Android provides a better experience for discourse users and marking the feature as completed [merefield](/t/-/365156/12, merefield.

It would be really nice if links shared to the Title instead of (just) the Post body so that the Title was populated automatically just like it does if you do that within a site.

Is there any reason why the Post body is the target?

1 Like

Would you accept a PR here or is there a reason why it was done this way?

@Falco what PR introduced this feature (I had a look but couldn’t track it down)?

This been a loooooong time ago, but won’t this break when you aren’t sharing a link but a textual content?

At least you’d had to detect if the sharing text is a link and send it to the proper field.

1 Like

Yeah, that’s presumably more challenging because aren’t you just GETing a URL e.g. https://blah.com/new-topic? ...

But happy to take a look

1 Like

If most sites are sending just a URL nowadays I’d be happy with the change.

1 Like

I’ve found the code :detective: and I’ll take a look if we can handle both … but agree URL’s are probably sent 99% of the time, so worth considering …

1 Like

OK I’ve worked out how to support both:

  • text shares will go to body
  • titles go to title
  • link shares will go to title (and then render as a fully expanded title and in the body a nice onebox upon instantiation with all that comes with that including topic list previews)

Currently the update is in a working plugin:

https://github.com/merefield/discourse-share-to-link-oneboxer

I’ll submit this as a PR as really a no brainer.

Tested this on both Android and Windows (Edge) PWAs and seems to work great.

1 Like

PR is here:

https://github.com/discourse/discourse/pull/32631

1 Like

Gentle reminder @Falco

2 Likes

Merged, thanks for the PR!

3 Likes

thanks for the review!

2 Likes

Confirmed this is working on latest rebuild

Another reason to consider Android over iOS for your next phone :mobile_phone: if addicted to Discourse-land :sweat_smile:

I think we can mark this as Completed?

3 Likes