בקשת תכונה: קישור לכותרת ולא לטקסט כאשר משתפים ל-discord PWA

סיכום מבוסס בינה מלאכותית

This feature request centers on improving how links are shared to the Discourse PWA. Originally, sharing a link would only populate the post body, not the title. merefield initiated the request, questioning the logic behind sharing to the body instead of the title merefield. @Falco attempted to pinpoint the PR that originally introduced the feature but found it difficult to trace Falco. Discussion arose around detecting link-based shares versus textual content [Falco](/t/-/365156/4, merefield. merefield then created a plugin—discourse-share-to-link-oneboxer—to support both text and link shares, with text going to the body, titles to the title, and links to the title with onebox rendering merefield. A pull request PR -32631 was submitted merefield and subsequently merged by @Falco Falco. merefield thanked @Falco for reviewing the PR. merefield has confirmed the update is working, noting Android provides a better experience for discourse users and marking the feature as completed [merefield](/t/-/365156/12, merefield.

יהיה ממש נחמד אם קישורים ישותפו לכותרת במקום (רק) לגוף הפוסט, כך שהכותרת תאוכלס אוטומטית בדיוק כמו שזה קורה אם עושים את זה בתוך אתר.

האם יש סיבה כלשהי לכך שגוף הפוסט הוא היעד?

לייק 1

האם תסכים ל-PR כאן או שיש סיבה שבגללה זה נעשה באופן זה?

@Falco באיזה PR הוכנסה תכונה זו (ביקרתי אך לא הצלחתי למצוא אותה)?

This been a loooooong time ago, but won’t this break when you aren’t sharing a link but a textual content?

At least you’d had to detect if the sharing text is a link and send it to the proper field.

לייק 1

Yeah, that’s presumably more challenging because aren’t you just GETing a URL e.g. https://blah.com/new-topic? ...

But happy to take a look

לייק 1

אם רוב האתרים שולחים רק URL בימינו, הייתי שמח עם השינוי.

לייק 1

I’ve found the code :detective: and I’ll take a look if we can handle both … but agree URL’s are probably sent 99% of the time, so worth considering …

לייק 1

OK I’ve worked out how to support both:

  • text shares will go to body
  • titles go to title
  • link shares will go to title (and then render as a fully expanded title and in the body a nice onebox upon instantiation with all that comes with that including topic list previews)

Currently the update is in a working plugin:

https://github.com/merefield/discourse-share-to-link-oneboxer

I’ll submit this as a PR as really a no brainer.

Tested this on both Android and Windows (Edge) PWAs and seems to work great.

לייק 1

PR is here:

https://github.com/discourse/discourse/pull/32631

לייק 1

תזכורת עדינה @Falco

2 לייקים

אוחד, תודה על הבקשה!

3 לייקים

תודה על הביקורת!

2 לייקים

Confirmed this is working on latest rebuild

Another reason to consider Android over iOS for your next phone :mobile_phone: if addicted to Discourse-land :sweat_smile:

I think we can mark this as Completed?

3 לייקים