Existing users don't get added to groups in an invite if they can already access the Topic the invite directs to

pento · May 16, 2025, 6:46am

Thanks for the bug report, @nathank!

I’ve just merged a fix for this:

github.com/discourse/discourse

FIX: Allow existing users to accept invites that add them to a group.

main ← pento/fix-invite-existing-user-to-group-with-redirect

opened 04:38AM - 16 May 25 UTC

pento

+48 -7

## ✨ What's This? This is a tweak to the change in #31301. That change all…owed existing users to be redirected to a topic that they already have access to by bypassing the invite acceptance step, and simply redirecting them there. Since some invites also add the invited user to one or more groups as well, this was causing the group adding step to be skipped in existing workflows. This change addresses the issue by checking to see if the user would be added to any groups before redirecting. To avoid introducing a CSRF issue, it works by forcing the user through the normal invite acceptance flow, ensure there's user interaction before being added to any groups. This change also tweaks the behaviour of #31301 to not follow redirects of expired invitations. ## 👑 Testing ### Basic functionality 1. Create a test user. 2. Create an invite that lands on a topic that the test user can access already. 3. Add a group to the invite (which the test user isn’t currently a member of). 4. Login as the test user. 5. Visit the invite link with that user. ### Variations 1. Add the test user to the group before they visit the link. 2. Add multiple groups to the invite, of which the test user is a member of some, or all.

Let me know if this fixes the issue for you, or if you run into any further problems!

Topic		Replies	Views
Invitation Links are Only Working for Non-existing Users & Breaking Our Current Implementation Bug invites	5	102	March 24, 2025
Inviting users with groups field failed when there is an existing user in the list Bug	8	837	April 22, 2019
New invite link should work for existing users Feature invites	14	1439	November 24, 2022
Invite links to topic send user to home page, not to topic Bug invites	20	1339	December 1, 2022
All newly and previously created invitation links are being invalidated after recent changes to the invitation system Bug invites	4	677	November 25, 2022

Existing users don't get added to groups in an invite if they can already access the Topic the invite directs to

Related topics