Currently running Discourse 3.5.0.beta5-dev (eff31e0d42). Would anyone know if the API response from the /admin/users/list/all.json endpoint has changed in the last week or so? :thinking: Specifically: GET /admin/users/list/all.json?email=email@example.com :thinking: I think this endpoint used to return a flat JSON object directly representing a single user when queried with an exact email address. However, the current response structure now appears to wrap the user object inside a new users array, which has broken a few existing SSO integrations at our end. Here is an anonymised pseudo example of the response of what I think has changed “before” and “after” for reference. Old: { "id": 1, "username": "sampleuser", "name": "", "avatar_template": "/user_avatar/example.com/sampleuser/{size}/avatar.png", "active": true, "admin": false, "moderator": false, "last_seen_at": "2025-05-11T08:27:28.578Z", "created_at": "2020-01-01T12:00:00.000Z", "suspended": false, "trust_level": 1 } New: { "users": [ { "id": 1, "username": "sampleuser", "name": "", "avatar_template": "/user_avatar/example.com/sampleuser/{size}/avatar.png", "email": "someone@example.com", "active": true, "admin": false, "moderator": false, "last_seen_at": "2025-05-11T09:34:35.900Z", "created_at": "2020-01-01T12:00:00.000Z", "suspended": false, "trust_level": 1 } ], "meta": { "message_bus_last_ids": { "bulk_delete": 0 } } } Would anyone know of a recent commit that may have caused this change? :thinking:

Hi, yes sorry this shouldn’t have been merged, it was my mistake. But the good news is that I already reverted it 8 hours ago: DEV: revert admin users list change (#32723) · discourse/discourse@7558e2c · GitHub

No amount of searching through the 73x commits I updated with yesterday found this DEV: replace selenium driver with playwright breaking change. Thanks for the link @RGJ

[imagem] Richie: searching through the 73x commits My approach: load /admin/users/list/all.json?email=email@example.com check the x-discourse-route header look up the corresponding file (app/controllers/admin/users_controller.rb) look up the corresponding method (index) press “Blame” spot the commit [image]

Nooooo way… :scream: Well, that’s what I learnt today! Thanks @RGJ :clap:t2::star_struck:

I managed to find that commit somehow, but couldn’t (and still don’t) see where it changed the data structure (I was on my phone, making things a bit more difficult).

I’m guessing this was the breaking change in the API response :confused: In /app/assets/javascripts/admin/addon/controllers/admin-users-list-show.js [Screenshot 2025-05-11 at 15.36.17]

[imagem] pfaffman: where it changed the data structure It’s the line root: :users that was added.

We’ve now recovered from the impact of this change. Perhaps going a bit off topic here but is there a way I can track these types of updates so I can notify myself when an API response changes from “X”, after being “Y” for so many years? :thinking: Some kind of scripted local unit tests that I could run on a daily basis perhaps? Although now I’ve said that out loud, that wouldn’t notify me until after I’d updated my Discourse and it had broken the integrations. A staging environment I guess…

You could have a staging environment. You might also create a github action for your code that starts discourse and runs a test against the latest discourse each day.

[imagem] pfaffman: runs a test against the latest discourse each day Ah-ha! Perfect, that’d work, thanks :grin:

I think a plugin that called the endpoint and rendered it could be an easy way to test. And then change the default github action to run daily instead of only on push.

Alterações na estrutura de resposta da API /admin/users/list/all.json?

Dev

RGJ (Richard - Communiteq) 11 Maio , 2025 15:12 9

É a linha root: :users que foi adicionada.

Tópico		Respostas	Vistas
Cases when admin/users.json?email=foobar or admin/users/list/all.json?email=foobar return empty array Development rest-api , user-api	5	399	29 Abril , 2025
Issues with the /get-users ending point Development rest-api	4	231	16 Julho , 2024
How do I get a list of all users from the API? Development rest-api	18	11432	24 Dezembro , 2021
Creating users through RESTFUL Users API - Users.json got wiped Development rest-api	4	1815	28 Fevereiro , 2019
Group API, empty response Development rest-api	6	1000	9 Novembro , 2020

Alterações na estrutura de resposta da API /admin/users/list/all.json?

Related topics