Bad inline onebox title for Spotify album shares

sam · August 11, 2025, 3:01am

Hmmm:

lib/retrieve_title.rb

b1e2ac3cc


      
          if doc
            title = doc.at("title")&.inner_text
          
            # A horrible hack - YouTube uses `document.title` to populate the title
            # for some reason. For any other site than YouTube this wouldn't be worth it.
            if title == "YouTube" && html =~ /document\.title *= *"(.*)";/
              title = Regexp.last_match[1].sub(/ - YouTube\z/, "")
            end
          
            if !title && node = doc.at('meta[property="og:title"]')
              title = node["content"]
            end
          end

Because <title> takes precedence over open graph in our implementation and we don’t want to hardcode the string “Unsupported browser”…

FIX: update final destination to use more recent user agent by SamSaffron · Pull Request #34207 · discourse/discourse · GitHub should fix this…

This feels way old though:

DEFAULT_USER_AGENT = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15"

Topic		Replies	Views
Why not fallback to inline-onebox if full-onebox fails? Dev	0	41	February 18, 2025
Onebox requests being incorrectly redirected due to user-agent Support	20	1713	November 28, 2022
Inline-onebox doesn't use SiteSetting.onebox_user_agent Feature onebox , pr-welcome	2	53	August 31, 2025
Inline links no longer fetch the HTML Title Support	4	53	February 8, 2025
Mini (Inline) Onebox Support RFC Feature rfc	21	5572	April 21, 2022

Bad inline onebox title for Spotify album shares

Related topics