A user denvergeeks reported that clicking the “All site settings” menu item in Discourse’s sidebar redirects to /admin/site_settings/category/required instead of /admin/site_settings/category/all_results, causing confusion and extra clicks. Others chapoi and pfaffman agreed it was odd, while Moin questioned whether “All” is accurate since it only displays 100 settings, not all 4,168. denvergeeks acknowledged the performance trade-off. martin proposed a fix via PR and noted the Ctrl+/ shortcut for searching settings. Moin suggested trimming “All” from translations due to sidebar space limits. hugh confirmed it was an oversight, approved martin’s PR to fix the redirect, and argued for keeping “All” as a label since filtering allows access to any setting. The PR was merged martin.
Another thought: We removed the “all” from “all site settings” in the German translation because of the limited space in the sidebar. Maybe it makes sense to do this for other languages too.
This feels like an oversight to me, and it should indeed be on the ‘All’ section of the page. An unfortunate side effect of it starting on ‘Required’ is that when you filter the results, it remains on ‘Required’ so there’s a chance you might not see what you were filtering to find.
That’s something to think about, but I would like to keep the ‘All’ in there, at least for now. Because the page can be filtered to show any of the site settings, ‘All’ is still a correct label. I’m happy to reeavluate that with more feedback about it, though.
