Disabled plugins still causing performance impact

Contribute Bug

AI-generated summary

The discussion addresses a performance issue caused by disabled plugins still executing queries, even when inactive. RGJ highlights that plugins like topic voting inject queries despite being disabled, referencing code in the plugin’s filter and registration logic. tgxworld acknowledges the report and tags it as #pri-medium. loic explains a PR has been submitted to fix the issue by making register_* calls behave properly, and confirms the PR has been merged. RGJ expresses gratitude, and loic follows up by creating a PR to backport the fix, ensuring broader compatibility.

1

Since a lot of plugins have been bundled with core, we’ve been seeing some performance impact.

When investigating, it turned out that some plugins are still injecting certain queries, even when disabled.

An example is the topic voting plugin.

The topic filter and the search filter and search order are always injected and active.

The code should be fenced with SiteSetting.topic_voting_enabled. Or maybe calls like register_search_advanced_filter should behave more like add_to_serializer and check if the plugin is enabled.

14 Likes
Bundling more popular plugins with Discourse core
2

Thank you for the report. I’ve tagged this pri-medium for now and someone from the team will look at it soon.

Also putting a pr-welcome on this :slight_smile:

4 Likes
4

I just finished a PR making most of the `register_*` calls behave like add_to_serializer:

https://github.com/discourse/discourse/pull/35630

4 Likes
5

The PR has just been merged, it should be available in latest shortly :slight_smile:

3 Likes
7

Thanks, that is fantastic :heart_eyes:
Would a backport to stable be a possibility for this fix ?

3 Likes
8

Sure, I just created a PR:

https://github.com/discourse/discourse/pull/35703

3 Likes