Undeleting replies does not change the topic's bump date

AI-generated summary

The issue concerns the bump date of a topic not being updated when a deleted reply is restored. Moin explains that deleting a reply resets the bump date, but undeleting it fails to restore the topic to the top of the latest list, making the reply less visible. This behavior changed after a code update, and the problem is acknowledged. zogstrip confirms a fix is coming via a pull request.

A reply that is accidentally deleted and restored is likely to be overlooked because deleting the reply resets the bump date to the date of the previous reply, but undeleting doesn’t change it back to the date of the latest reply.

Steps to reproduce:

  1. Reply to a topic that wasn’t bumped recently
  2. Check latest to verify that the topic was bumped to the top
  3. Delete your reply
  4. Check latest to ensure the bump date was reset as expected
  5. Undelete your reply

Expected result: The topic is back at the top of latest, because there is a recent reply
Actual result: The topic is still where it was when the reply was deleted, which means it’s less likely someone will notice the reply

Note: This was still working after FEATURE: Reset bump date when deleting a post by Lhcfl · Pull Request #33747 · discourse/discourse · GitHub was merged. I think the reason is that undeleting was an edit that triggered the bump of the topic. But since FEATURE: Do not bump topic on post edit by martin-brennan · Pull Request #34681 · discourse/discourse · GitHub this doesn’t work anymore

2 Likes

Thanks @Moin someone will have a look over the next few weeks.

This shall be fixed by

https://github.com/discourse/discourse/pull/36935

Happy New Year :tada:

3 Likes