Approve changes button does not disappear when adding a user to a custom group from their user admin page

zogstrip · 7 בפברואר,‏ 2026,‏ 11:14pm

Another page that would be better suited for a proper refactoring to Glimmer

In the meantime, here’s the fix

github.com/discourse/discourse

FIX: Custom groups save button not clearing on admin user page (#37625)

main ← fix/admin-user-custom-groups-save

opened 11:13PM - 07 Feb 26 UTC

ZogStriP

+96 -28

The approve/reject buttons for custom group changes on the admin user page would… remain visible after saving, even though the changes were persisted successfully. Removing a group also failed to update the UI. Three issues in the reactivity chain caused this: 1. The `@filter` computed macros (classic Ember) on the AdminUser model did not react to `@trackedArray` mutations. Replaced `customGroups` and `automaticGroups` with native getters so they participate in Glimmer autotracking. 2. The controller's `groupAdded()` and `groupRemoved()` wrappers did not return their promise chains, so `await` in `saveCustomGroups()` resolved immediately before the API calls completed and before the groups array was updated. 3. The controller's `customGroupIds`, `customGroupsDirty`, and `automaticGroups` used `@discourseComputed` which could not track changes from native getters on the model. Converted these to native getters and made `customGroupIdsBuffer` `@tracked`. Additionally, `saveCustomGroups()` now awaits each operation sequentially and calls `resetCustomGroups()` on completion to sync the buffer with the updated group list, clearing the dirty state. Note: only the properties involved in the groups reactivity chain were converted to modern Glimmer patterns. The rest of the controller and model still use classic Ember (`@discourseComputed`, `this.set`, etc.) and can be modernized separately. Ref - https://meta.discourse.org/t/395210

נושא		תגובות	צפיות
Custom groups field is blank Bug	4	1162	16 באפריל,‏ 2015
Users custom group membership not shown Bug groups	2	1116	16 באפריל,‏ 2015
Adding owners/members UX is inconsistent and misleading UX	26	3029	20 באפריל,‏ 2018
Unable to save changes to a Group Bug	6	624	12 באפריל,‏ 2018
Improved Group Members Management Feature rfc , spec	31	11180	7 בינואר,‏ 2016

Approve changes button does not disappear when adding a user to a custom group from their user admin page

נושאים קשורים