Poll option marker overlapping mention pills

Contribute Bug

AI-generated summary

elRicharde reported a bug where mention pills in poll options overlapped with the option markers or checkboxes due to a missing layout container. The proposed CSS-only fix converts poll option list items into flex rows to ensure side-by-side alignment. elRicharde provided screenshots demonstrating the glitch and the corrected layout, along with code to reproduce the issue. Initially, the fix was submitted to a personal fork, prompting Moin to clarify that pull requests should target the main discourse/discourse repository for team review. merefield guided elRicharde on how to create a cross-fork pull request, which elRicharde subsequently did 37972. sam approved the visual direction of the fix and requested a design review. Finally, derek confirmed that the fix looks great and has been merged into the main branch.

1

Poll option list items had no layout container, allowing @mentionmention pills to overlap the option marker or checkbox.

This change makes poll options flex rows so marker and content are always laid out side by side.

CSS only, no behavior or markup changes.

Repro:
Create a poll with options that i@mentionsclude @mentions (mention pills).
In the cooked topic view, the option marker/checkbox can overlap the mention pill.

Fix:
Make poll option list items a flex row so the marker/checkbox and the option content
are laid out side by side with consistent spacing.

Screenshots show the overlap before the change.

Poll before, preview ok:

Screenshot 2026-02-08 093307
Screenshot 2026-02-08 0933071475×575 38 KB

Poll with glitch:

Screenshot 2026-02-08 093403
Screenshot 2026-02-08 093403791×743 36.4 KB

After Fix:

Screenshot 2026-02-08 093356
Screenshot 2026-02-08 093356900×878 41.7 KB

PR:

https://github.com/elRicharde/discourse/pull/1

Code to Reproduce:

Checkbox behavior Ok

[ ] @Richarde
[ ] @discobot

# Polls glitch when mention pills are used @elRicharde @discobot but not in preview

[poll type=multiple results=on_close name=glitchMentionPills chartType=bar close=2028-02-06T21:45:00.000CET groups=mitglieder max=4 min=1]
* @elRicharde
* @discobot
* [date=2026-02-12 time=17:00:00 timezone=Europe/Berlin]
* [date=2026-02-13 time=18:00:00 timezone=Europe/Berlin]
* normale Text
* 2nd normal TextOption

[/poll]

Checkbox behavior Ok

@elRicharde
@discobot

Polls glitch when mention pills are used @Richarde @discobot but not in preview

  • @elRicharde
  • @discobot
  • 2026-02-12T16:00:00Z
  • 2026-02-13T17:00:00Z
  • normale Text
  • 2nd normal TextOption
0 voters

[/poll]

3 Likes
2

Hey just wondering when this will probably go to the main branch? Don´t want to patch my core with my own fix to prevent merge conflicts with Updates in future.
I prefer waiting for the commit to be merged with main, but also wonder how the process will be from here and when.
Thanks in advance.

3

Hmm, it looks to me like the pull request you linked is targeting your own fork rather than the main discourse/discourse repository. Is there a specific reason why you didn’t open the pull request against the main repository instead?

Usually, the team approves and merges pull requests there. I am not sure they usually look at PRs on forks. Maybe @zogstrip didn’t notice that when he reviewed this.

3 Likes
4

ah, ok. Thought it will lead to the main branch anyways or pop up there to accept the changes. but i´m not very familar with that and would need support here.

Is the actual state a real dead end if i don´t follow some steps or can somone anyways merge this to the main branch?

Sorry and thanks for your help.

BR Richard

5

Yeah, there are probably a few ways to do this but you want to go to:

Pull requests · discourse/discourse · GitHub

Hit:

New pull request

then:

compare across forks

and complete the mapping and initiate it.

1 Like
6

Thanks, done that

https://github.com/discourse/discourse/pull/37972

4 Likes
7

to my non designer eyes the direction of the fix looks great.

will ping an @interrupt-designer to have a look and see if we can merge the PR :hugs: and thanks.

3 Likes
9

Thanks @elRicharde, the fix looks great. It’s merged now.

2 Likes