Notifications menu shows raw backslash escapes in titles

sam · March 10, 2017, 9:43pm

I see… was reading through the code, will leave it for @codinghorror to decide.

The reason this happens is due to:

lib/html_prettify.rb

5dbd6a304


      
          # Return the string, with after processing the following backslash
          # escape sequences. This is useful if you want to force a "dumb" quote
          # or other character to appear.
          #
          # Escaped are:
          #      \\    \"    \'    \.    \-    \`
          #
          def process_escapes(str)
            str = str.gsub('\\\\', '&#92;')
            str.gsub!('\"',   '&#34;')
            str.gsub!("\\\'", '&#39;')
            str.gsub!('\.',   '&#46;')
            str.gsub!('\-',   '&#45;')
            str.gsub!('\`',   '&#96;')
            str
          end

Should I remove this magic?

Or maybe our topic titles should be passed through the prettfier prior to being sent as notifications. Not sure.

Topic		Replies	Views
<span class="search-highlight"> showing up in search results Bug	2	384	November 28, 2023
`’` in topic titles on oops page Bug fixed	3	249	June 29, 2026
Pasting a link in the composer's title field trims the title if there's a quote character in it Bug	2	559	June 8, 2022
Post title's HTML not rendered right as bookmark in profile menu UX bookmarks	2	171	September 16, 2025
Emojis in post titles are not rendered in invite-to-topic emails Bug	4	1623	April 12, 2017

Notifications menu shows raw backslash escapes in titles

Related topics