Google Maps Onebox data is not cached

glebm · March 16, 2017, 1:15am

@mpalmer Good point, I haven’t realized the intent is to respect the cache headers.

However, the onebox currently does not respect the headers. Instead, it always caches everything forever.

lib/onebox/engine.rb

main


      
              @url = @uri.to_s
            end
            @timeout = timeout || Onebox.options.timeout
          end
          
          # raises error if not defined in onebox engine.
          # This is the output method for an engine.
          def to_html
            fail NoMethodError, "Engines need to implement this method"
          end
          
          # Some oneboxes create iframes or other complicated controls. If you're using
          # a live editor with HTML preview, rendering those complicated controls can
          # be slow or cause flickering.
          #
          # This method allows engines to produce a placeholder such as static image
          # frame of a video.
          #
          # By default it just calls `to_html` unless implemented.
          def placeholder_html
            to_html

It only does the correct thing for Google Maps currently by accident. If Google Maps changes the cache headers tomorrow, it will no longer do the correct thing.

Topic		Replies	Views
Google Maps onebox issues Bug	15	3782	January 1, 2016
Does onebox gem cache the generic urls? Product Support	5	955	November 2, 2019
Does Onebox engine cache content locally? Product Support	4	1774	July 17, 2017
How to read from cache only using onebox gem? Development	1	523	April 30, 2019
Why are oneboxes cached into posts? Feature	9	1500	December 20, 2020

Google Maps Onebox data is not cached

Related topics