Hi, hope I’m asking at the right place! We want to use a hosted (as in paid) discourse account and embed it on three sites to power their comment sections. It is my understanding that I would need to whitelist 3 domains as cors origins which I’ve done like so: https://dl.dropboxusercontent.com/s/4zrqarqjln7qj8k/2017-08-16%20at%2020.16.png It seems however upon some testing that only the first domain is returned: https://dl.dropboxusercontent.com/s/jctq7uejd8lbqbj/2017-08-16%20at%2020.22.png It is my understanding that it’s not possible to return multiple origins in the cors header. In our company we’ve worked around that by checking the origin, and matching it against a short whitelist. If it occurs, we return that specific origin for the current request. That way multiple origins can indeed be supported. Could this be something you’d be willing to support/implement or should we go for a self-hosted solution and hack around this? For one thing, I think the way the interface is now, you would expect it allows multiple origins. Would be awesome if you’d consider this, as I’m looking forward very much to building a community for our open source projects with discourse! <3

@sam thinks we have fixed this, and have deployed, can you try again and let us know?

If the origin of the request matches one of the listed origins, then we return that as the allowed CORS origin. config/initializers/008-rack-cors.rb main headers ||= {} Discourse::Cors.apply_headers(cors_origins, env, headers) So it should already be working for you.

Okay then it must be something fishy on my end. I’ll dive deeper, thanks a lot for verifying this for me!

So, as far as I can tell, all requests are coming through correctly. Here are the ones from discourse.org: [image] And these are from our https://community.transloadit.com server: [image] There are no errors in the console (that relate to discourse, or would stop javascript execution): [image] Yet I keep seeing that “Error Embedding” message when testing locally. From the server side, I have configured these four allowed embedding hosts: [image] .. as well as enabled these CORS origins: [image] which according to these instructions are the common things that go wrong. I’m sure I’m doing something silly but since there’s no error I’m unsure how to debug this further. Would you have clues?

Just deployed it to production so you can have a look: Releasing our official Python SDK | Transloadit Getting these errors: Refused to display 'https://community.transloadit.com/' in a frame because it set 'X-Frame-Options' to 'sameorigin'. (which I believe is set on your end and should really allow us to iframe, correct?) and: VM2928 comments?embed_url=https%3A%2F%2Ftransloadit.com%2Fblog%2F2017%2F08%2Fpython-sdk-release%2F:17 Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://community.transloadit.com') does not match the recipient window's origin ('https://transloadit.com'). postUp @ VM2928 comments?embed_url=https%3A%2F%2Ftransloadit.com%2Fblog%2F2017%2F08%2Fpython-sdk-release%2F:17 window.onload @ VM2928 comments?embed_url=https%3A%2F%2Ftransloadit.com%2Fblog%2F2017%2F08%2Fpython-sdk-release%2F:38 Which just confuses me a great deal :slight_smile: You can see topics are being created now: https://community.transloadit.com/t/major-improvements-to-our-go-sdk/276 But the iframing does not work. Could this be because we enabled HTTPS and your HTTPS terminator sets some additional security enhancing headers that are not compatible with embedding?

Just tested and it works like a charm! Thanks for the fix, and thanks for a great product!

Note, the error was actually nothing to do with the CORS origins, instead it was a particular HTML structure our “except parser” exploded on. If you had empty content in certain nodes we were totally unable to generate excerpts, something that broke topic creation.

Multiple cors origins on hosted discourse?

Product Support

supermathie (Michael Brown) August 17, 2017, 10:36pm 7

Hi, just wanted to let you know we’re taking a look at this.

Topic		Replies	Views
CORS Error when embedding comments in Gitlab-hosted Jekyll static site Product Support	3	1103	October 17, 2017
Where I should go to set the `DISCOURSE_ENABLE_CORS` env variable? Product Support	16	1357	December 27, 2022
Failed to execute postMessage on DOMWindow: The target origin provided does not match Self-hosting	6	18533	January 5, 2018
X-Frame Origin Embed Error Product Support	14	5544	July 20, 2020
CORS origins setup does not work Product Support	6	2121	October 22, 2020

Multiple cors origins on hosted discourse?

Related topics