Orientation fix missing in latest stable

RGJ · February 3, 2018, 8:45am

Saturday morning is always a good moment to research weird problems.
I suddenly see things that I’ve overlooked for a long time.

The image orientation fix seems to be missing in the stable branch.

Can you please, please backport it for 1.9.3 ?

Master:

github.com/discourse/discourse

lib/upload_creator.rb

main


      
          def initialize(file, filename, opts = {})
            @file = file
            @filename = (filename || "").gsub(/[^[:print:]]/, "")
            @upload = Upload.new(original_filename: @filename, filesize: 0)
            @opts = opts
            @filesize = @opts[:filesize] if @opts[:external_upload_too_big]
            @opts[:validate] = (
              if opts[:skip_validations].present?

Stable:

github.com/discourse/discourse

lib/upload_creator.rb

stable


      
          def initialize(file, filename, opts = {})
            @file = file
            @filename = (filename || "").gsub(/[^[:print:]]/, "")
            @upload = Upload.new(original_filename: @filename, filesize: 0)
            @opts = opts
            @filesize = @opts[:filesize] if @opts[:external_upload_too_big]
            @opts[:validate] = (

codinghorror · February 3, 2018, 3:16pm

Sure @zogstrip can you take a look?

RGJ · February 4, 2018, 6:31pm

I did a diff between stable 1.9.0 and tests-passed 2.0 beta1, which should be pretty much the same, and I found three more differences which should not be there.

https://github.com/discourse/discourse/blob/stable/lib/validators/upload_url_validator.rb#L6
https://github.com/discourse/discourse/blob/master/lib/validators/upload_url_validator.rb#L6

https://github.com/discourse/discourse/blame/stable/app/assets/javascripts/discourse/templates/components/group-membership-button.hbs#L28-L31

RGJ · February 16, 2018, 5:03pm

@zogstrip @neil do you have any plans to merge these changes back in to stable ?

zogstrip · February 16, 2018, 5:06pm

Yup. Topic isn’t closed and still is assigned Just haven’t got a chance to do it yet.

RGJ · May 17, 2018, 12:17pm

Would it be possible to merge the image rotation bugfix back into stable before Discourse 2.0 stable is being released? It’s only a single line in upload_creator.rb that is still causing a lot of headaches.

zogstrip · May 17, 2018, 12:56pm

Sorry for the delay. It’s now backported

https://github.com/discourse/discourse/commit/82148a168f6dfe051c22faeeb56ad2e49a71d59a

zogstrip · May 17, 2018, 4:00pm

This topic was automatically closed after 3 hours. New replies are no longer allowed.

Topic		Replies	Views
Orientation of images uploaded is wrong Product Support	18	2434	January 18, 2018
Is there a way to manually rotate an image Product Support	29	7126	December 12, 2020
Mobile image upload turns sideways Product Support	32	13894	June 23, 2017
Stable is well... broken Product Support	6	1289	April 5, 2018
2.8.2: Minor Patch Release Announcements release-notes	0	486	March 22, 2022

Orientation fix missing in latest stable

AI-generated summary

Related topics