Tagging Korean Words

סיכום מבוסס בינה מלאכותית

In the discussion on Tagging Korean Words, anton1226 reported a bug where the cursor stays at the start of the textbox when trying to add a Korean word as a tag. joffreyjaffeux was unable to reproduce the issue on various browsers, prompting anton1226 to provide further details. riking and schungx suspected it was an IME-related issue, which schungx confirmed after experiencing the same problem with Chinese.

schungx conducted further experimentation and found that typing works when the auto-complete list is finished loading, but doesn’t work when the “loading” gif is on. joffreyjaffeux suspected the issue was due to a character range problem and later identified the problematic line. A potential fix was identified in this pull request, which was merged by joffreyjaffeux after some uncertainty about its consequences.

Hello, I’ve been using Discourse as our official forum for my game. And it’s been a great pleasure to use such a sophisticated platform as our forum.

And while using it in Korean, I encountered a tiny problem:

1524805032958

This bug occurs when I try to tag Korean words. As you can see in the picture above, when I try to add a Korean word as a tag, the cursor stays at the start of the textbox.

As for the version I am using, it’s v2.0.0.beta7 +14.

Please feel free to ask for further details if you need any.

2 לייקים

Hi, I’ve been unable to reproduce this on chrome/firefox/edge

can you give me clear reproduction please?

לייק 1

This probably has something to do with a custom IME.

לייק 1

Yes, it is an IME issue. The text box is trapping key down events necessary for the IME to work.

It is the same situation with Chinese. I had to first use a text editor to type the text, then paste into the text box.

It didn’t use to do that in earlier versions.

So i suspect that the text box is not useable for languages requiring an IME.

Yes I have an idea about this, it’s probably due to some char range. Will investigate.

3 לייקים

I have done some experimentation and found out this for CJK:

  • Typing when the “loading” gif is on (i.e. loading the auto-complete list): Doesn’t work. It will jump all over the place, or escape out the IME characters.

  • Typing when the “loading” gif if off (i.e. finished loading the auto-complete list): Works.

Yes I think I have identified the problematic line, thanks for testing more.

3 לייקים

MIGHT be fixed by (I still can’t reproduce) FIX: allows more chars than a-z in select-kit by jjaffeux · Pull Request #5889 · discourse/discourse · GitHub

I will wait for 2.0 release before merging this though, I’m unsure about some consequences.

4 לייקים

I merged this fix today.

2 לייקים