404 on various categories

기여 버그
1

Hello all,

after we upgraded our forum to 2.4.0beta6, we noticed that various categories lead to a 404 error page.
And after you reach this 404 error page, when you hit the forum logo (to go the home page) it just stays in the 404 page. So, we suspect the front-end reaches a “bad” state.

This call returns a 404:
https://rembetiko.gr/c/%CE%B8%CE%AD%CF%83%CE%B5%CE%B9%CF%82-%CE%B1%CE%BD%CF%84%CE%B9%CE%B8%CE%AD%CF%83%CE%B5%CE%B9%CF%82/find_by_slug.json

If it helps, sometime in the past, we changed our slugs from Encoded back to ASCII. But as it seems, the categories slug never changed. We tried changing the slugs from ASCII to Encoded, but nothing changed. (deleted cache etc.)

You can see the problem on our discourse instance: https://rembetiko.gr

Any suggestions? We suspect some kind of bug here…

5개의 좋아요
2

Interesting, any ideas @falco?

3개의 좋아요
3

Oh I may have forgotten about category slugs in my latest patch, where I fixed only the topics slugs.

Will take a look on Monday.

6개의 좋아요
5

Is this the commit you are referring to?

https://github.com/discourse/discourse/commit/76ab0350f19e72cf33395768a8ce6736fec9565e

2개의 좋아요
6

Yes that one.

I’m fixing what is broken on categories on this PR:

https://github.com/discourse/discourse/pull/8191

To be honest, I kinda regret the initial fix as it is touching too much of the code to handle encoded URLs.

4개의 좋아요
7

So is this fully fixed now or still WIP?

2개의 좋아요
8

I have exactly the same problem in my forum :roll_eyes:, after updating a few minutes ago to: 2.4.0.beta6 [a37dafdd4d]

Error 404 seems to appear only in the categories that have “accent” in their text.

I hope you can release the patch and update soon as it breaks the proper functioning of the forum.

Thanks!

1개의 좋아요
9

@TroyaNO @azawawi @chrispanag @Jeremie_Leroy just merged another round of fixes, please update and check it out.

Also closing this in favor of Topic with Japanese in URL doesn't redirect if URL doesn't perfectly match

4개의 좋아요
Topic with Japanese in URL doesn't redirect if URL doesn't perfectly match