In the discussion “Accepted Invitations still Unread,” users report an issue where notifications for accepted invitations remain marked as unread even after clicking on them. ndalliard shares a screenshot illustrating the problem. Multiple users, including buluma_michael, experience the same issue and find that refreshing the page or logging out and back in does not resolve it.
Mittineague suggests a page refresh should clear the notifications, but buluma_michael finds this does not work. sam agrees that the issue should be fixed.
As a temporary solution, techAPJ recommends manually clearing notifications by going to the Notifications tab and clicking the “Mark all as Read” button. Mittineague notes this is the same method used to clear other types of notifications.
Upon investigating, techAPJ finds that the issue is due to a lack of code handling this specific case and proposes marking “Invite Accepted” notifications as read by default, similar to badge notifications. sam agrees with this solution. The issue has since been fixed via a commit to the Discourse GitHub repository, as reported by techAPJ.
Even tough I clicked on the notifications, about the accepted Invitations, it is still marked as unread:
I am running: v1.4.0.beta8 +37
I just saw, that when I am on the users page I’ve invited, the unread mark is gone for a moment. But its coming back.
Same thing happens for me. I’ll attempt logging out and back in again.
You shouldn’t need to log out and back in. Usually a page refresh will clear them.
@Mittineague that’s right but browser refresh does not seem to clear this.
Yeah, we need to clear this on click through @techAPJ can you add to your list
Sorry about that. Until the proper fix is in place you can clear the notifications manually by going to your Notifications tab – http://discourse.example.com/users/username/notifications – and then click on “Mark all as Read” button.
Ah yes, same method I use to clear the “_ posts moved” Notifications.
(though we’re 5 betas behind so maybe that has been fixed.)
I looked into this bug today and it seems like this issue has been present in our source code for a while. There is no code handling this case (i.e. marking invite accepted notification as read) at present.
In my opinion “Invite Accepted” notifications should show up as read, like we do with badges notifications. This will be useful in case of “Bulk/Disposable Invites”.
Thoughts @codinghorror / @sam ?
Sure that is fine, have it show up “read”
Okay, fixed via:
https://github.com/discourse/discourse/commit/eb941475fa405a102e66485e2ca9b84720144b21
