riking
16. Januar 2018 um 02:33
3
Here’s a PR. Does not fix the … issue.
Wrote the comment entirely with my keyboard after I decided that would be a good idea, and found another issue: we need a shortcut to focus the composer textarea . It was extremely annoying to get my focus back in the composer, especially because it’s not where I expected it to be in the taborder.
master ← riking:topic-focus
closed 01:02AM - 23 Feb 18 UTC
This work is a prerequisite to pointing screen readers at the right spot when yo… u enter in the middle of a topic.
- Applied hover styling to post actions when focused - this way, you can actually see that the button is tabbed to instead of being entirely invisible.
- Made topic posts, and topic list items, valid tab targets.
- Removed the `<a class=tabLoc>` at the start of every post, because the post itself is now a valid target.
- Made the J/K keyboard navigation focus each post / topic list item, and use focus as the first test for what's currently selected.
- The obvious complement to that is to use the existing `.selected` styling for when the element is focused. *Edge does not support the `:focus-within` selector*, so we need to use JS to track this.
- A final cleanup commit to set `outline: 0` on our newly focusable elements, since they have custom styling.
5 „Gefällt mir“