Add ability to Embed GitLab Onebox by displaying the code inside like GitHub Does in Discourse.
לייק 1
Gitlab needs to support it. Onebox probably has nothing to do with it.
Have you checked how they render on iframely?
3 לייקים
I’m not so sure. Gitlab is similar to Github, which has its own onebox engine/rule
https://github.com/discourse/onebox/tree/master/lib/onebox/engine
5 לייקים
So github is treated differently?
Yes. It has a few custom engines to one box it’s urls
3 לייקים
Oh okay! I was unaware of it.
We’d be happy to support a PR that adds custom onebox behaviors for GitLab.
7 לייקים
https://github.com/discourse/onebox/pull/385
A plugin as well:
https://github.com/misaka4e21/discourse-onebox-gitlab
5 לייקים
This is very cool, but I feel like we should just fold it all into onebox, no need to add one more plugin here.
Can you show some screenshots of how it looks?
Excellent work @misaka4e21!
4 לייקים
The plugin will only be necessary when the pull request is not merged. All things in the plugin are included in the PR.
(It seems that the GitHub icon is wrongly displayed.)
2 לייקים
cool lets get the icon sorted as well, also the spacing the the gutter looks really big.
The GitHub favicon is now removed for GitLab. The independent icon of GitLab should be added to the discourse
onebox.scss and assets instead of the onebox repo, in order to be shown.
As for the spacing issue, it is the same as current GitHub ones.
https://github.com/discourse/discourse/blob/master/README.md#L1
5 לייקים
Hmm, this only supports gitlab.com urls, not other domains?
Here’s an example:
2 לייקים
Yes it currently supports only gitlab.com.
Should we match any URL with pattern /<user>/<repo>/blob/<branch|commit>/<path> without checking it to be a GitLab instance?
And, there is also other git hosting platform, such as gogs: libreCMC/libreCMC @ v1.4 - libreCMC
I searched for identifying elements, and there’s nothing good in the <head>, but body[data-page="projects:blob:show"] might be a good one.
Of cousre, Discourse has <meta name="generator" content="Discourse..."> 
2 לייקים
I think gitlab.com only for now is fine, we can further refine it later.
5 לייקים