Add ability to Embed GitLab Onebox

기여 기능
1

Add ability to Embed GitLab Onebox by displaying the code inside like GitHub Does in Discourse.

https://gitlab.com/DevsPen/Theme/blob/master/about.json

1개의 좋아요
2

Gitlab needs to support it. Onebox probably has nothing to do with it.

Have you checked how they render on iframely?

3개의 좋아요
3

I’m not so sure. Gitlab is similar to Github, which has its own onebox engine/rule

onebox/lib/onebox/engine at main · discourse/onebox · GitHub

5개의 좋아요
4

So github is treated differently?

5

Yes. It has a few custom engines to one box it’s urls

3개의 좋아요
6

Oh okay! I was unaware of it.

7

We’d be happy to support a PR that adds custom onebox behaviors for GitLab.

7개의 좋아요
8

https://github.com/discourse/onebox/pull/385

A plugin as well:
https://github.com/misaka4e21/discourse-onebox-gitlab

5개의 좋아요
9

This is very cool, but I feel like we should just fold it all into onebox, no need to add one more plugin here.

Can you show some screenshots of how it looks?

Excellent work @misaka4e21!

4개의 좋아요
10

The plugin will only be necessary when the pull request is not merged. All things in the plugin are included in the PR.

%E5%9C%96%E7%89%87
%E5%9C%96%E7%89%87667×320 21.8 KB

(It seems that the GitHub icon is wrongly displayed.)

2개의 좋아요
11

cool lets get the icon sorted as well, also the spacing the the gutter looks really big.

12

%E5%9C%96%E7%89%87
%E5%9C%96%E7%89%87713×419 39.2 KB

The GitHub favicon is now removed for GitLab. The independent icon of GitLab should be added to the discourse onebox.scss and assets instead of the onebox repo, in order to be shown.

As for the spacing issue, it is the same as current GitHub ones.

5개의 좋아요
13

Hmm, this only supports gitlab.com urls, not other domains?

Here’s an example:

https://git.pleroma.social/pleroma/pleroma/blob/develop/mix.exs#L28-30

2개의 좋아요
14

Yes it currently supports only gitlab.com.

Should we match any URL with pattern /<user>/<repo>/blob/<branch|commit>/<path> without checking it to be a GitLab instance?

And, there is also other git hosting platform, such as gogs: Making sure you're not a bot!

15

I searched for identifying elements, and there’s nothing good in the <head>, but body[data-page="projects:blob:show"] might be a good one.

Of cousre, Discourse has <meta name="generator" content="Discourse..."> :wink:

2개의 좋아요
16

I think gitlab.com only for now is fine, we can further refine it later.

5개의 좋아요