사용자에게 부여된 플래그를 제거하는 기능 추가

Mattia · 6월 5, 2021, 8:23오전

안녕하세요 ,

사용자에게 부여된 플래그를 제거할 수 있는 함수나 버튼이 있으면 유용할 것 같습니다. 이는 модератор들에게도 매우 유용할 것입니다.

즉, 한 사용자가 다른 사용자에게 플래그를 부여하면, 해당 플래그는 관리자/모더레이터만 볼 수 있도록 프로필에 남게 됩니다. 이미 부여된 이러한 플래그를 삭제할 수 있으면 좋겠습니다.

kelv · 6월 5, 2023, 7:11오전

이 기능을 작업하면서 MR을 통해 진행 상황을 업데이트할게요

kelv · 8월 1, 2023, 8:44오전

이 문제를 부분적으로 해결하는 수정이 병합되었습니다. 이제 플래그 카운터에서는 승인된 표준 플래그가 있는 게시글만 집계합니다. 이를 통해 해당 카운터의 노이즈가 줄어들어야 합니다.

github.com/discourse/discourse

FEATURE: Count only approved flagged posts in user pages (#22799)

main ← feat-only-count-approved-flags-for-counters

merged 05:33AM - 31 Jul 23 UTC

tyb-talks

+102 -15

#### Context Related topics: 1. Public Request: https://meta.discourse.org/t/…add-function-to-remove-flags-given-to-a-user/192750 This PR achieves the goal of reducing noise from flagged posts for admins/moderators by updating the counters in the user's profile page & admin view to only count posts with approved flags. This more accurately reflects the signal from posts that were correctly flagged, and removes the noise from flags that were rejected, ignored or awaiting review. #### Changes * Modifying User#number_of_flagged_posts to only return the count of posts with approved flags, and associated model unit tests * Updating the flagged post staff counter hyperlink to navigate to a filtered view of that user's approved flagged posts to maintain consistency with the counter * Adding system tests for the profile page to cover the flagged posts staff counter * Minor refactor of the user profile page object used for system testing * Modifying User#flags_received_count to return posts with only approved standard flags * Updating the `Show flags given` button in the user admin view to navigate to a filtered view of that user's approved flagged posts #### Testing How to test: 1. Populate a dev instance with topics & posts (with at least 5 from a specific user - this will be the flagged user) 4. All posts to be flagged should be from the same user. 5. Flag 3 posts with standard flags (i.e. `spam`, `inappropriate`, `off topic`). 6. As an admin/mod, review 2 of these posts with reject / ignore actions respectively, the last of these posts should be left as pending review. 7. Flag 1 post with a custom flag (i.e. `something else`) 8. Flag 1 post with 1 custom & 1 standard flag (you will need 2 different users here) 9. As an admin/mod, approve the flags from both posts above. 10. Navigate to the user's profile page and test for expected behaviour. 11. Navigate to the user's admin view via the Admin index of users search page and test for expected behaviour. Testing Artifact: https://github.com/discourse/discourse/assets/133760061/dd322974-285a-425f-8247-25a365f0c9e3 - 00:00 - 00:15 - Scrolling through 5 flagged posts, showing 1 pending, 1 rejected, 1 ignored and 2 approved (of which, one has all custom flags, and the other a mix of standard/custom flags) - 00:15 - 00:25 - Click through to user profile page to show flagged posts counter, and click on that counter to view approved flagged posts for that user - Expectation: Flagged Post counter should count all approved flagged posts - 00:32 - 00:42 - View user page through admin users index, click through on Show Received Flags button to view approved flagged posts for that user - Expectation: Received Flags counter should count all approved flagged posts with only standard flags #### Considerations / Questions 1. `User#flags_received_count` and `User#number_of_flagged_posts` differ in **2 key aspects - the latter includes custom flags and includes flags from deleted posts**. It is possible that including custom flags in the count adds noise (the extent of which depends on the proportion of custom flags used for non-negative flagging, and also whether the counters should be interpreted as wholly negative signals in the first place). ~I don't have enough data to opine either way (other than [anecdata](https://meta.discourse.org/t/please-distinguish-flags-for-bad-things-from-organizational-and-please-help-flags/266073/2)) so would like some input on the approach here if we want to maintain consistency between the counters in the user's profile page & the user's admin view.~ **(UPDATE: we have decided to go forward with consistent behaviour for both methods which exclude custom flags and include flags of deleted posts)** 2. The other tricky part if we opt to exclude custom flags from the count is that the filtered view upon clicking on the `flagged-posts` counter / `Show Flags Received` button currently has no way to filter out posts with only custom flags (if we want to differentiate the 2, perhaps this could be the subject of a future PR). --- _This PR was ported from a previous one (https://github.com/discourse/discourse/pull/22146), changes made in that earlier PR are captured in this first commit of this PR, and any updates from then are in subsequent commits. I'll squash everything prior to merge so we maintain a clean commit message._

글		댓글	조회수
Search/Filter Flags by User Feature completed , review-queue	12	1644	12월 10, 2024
Show what action was taken and by who for Flags Feature	2	949	4월 12, 2014
On Admin/User, Should "flags received" include Rejected? Feature	1	484	6월 10, 2019
Dashboard Report - User Flagging Ratio Data & reporting sql-query , dashboard-reports , dashboard-sql	0	399	2월 6, 2024
Delete approved flag Product Support	0	459	2월 8, 2021