I took this experimental_impersonation feature for a spin and it looks good! It does what is on the tin, and I appreciate not having to jump through the hoops of logging out and then logging in again as myself.
@moin raised in 🇩🇪 Fehler in der Deutschen Übersetzung? Hier melden! - #108 by Moin that “impersonate” and “stop impersonating” does not translate well into German. It’s hard to find the right words that capture the full meaning of what you are doing. This may be the case for other languages too but I have not checked.
I wonder if we want to switch (pun intended) to more straightforward terms such as Switch to @user_to_impersonate on the user admin page and then Switch back to @user_who_impersonated on the button to stop impersonating. That would likely be easier to translate and also easier to grasp for non-native english speakers.
Testing today also uncovered some other issues:
- I think there needs to be a modal to impersonate, similar to deleting or merging. This lets you back out in case you hit the button accidentally, and also educates the admin about what you are about to do, that it will be logged, and that you will be able to switch back without having to log in again.
- The fact that you are impersonating and switching back is logged in the staff action log, but any actions taking while impersonating are not logged. I think it would make sense to log that too given how rife this feature is to be abused, accidentially or intentionally.
- An age old problem still persists, which is that when you impersonate a user it bumps their last seen date in the user list and user admin, and (presumably) in “who’s online” if that plugin is installed.