Adding a stable way of adding whitelisted "orphaned" uploads in a plugin

sam · 2019 年 9 月 12 日午前 6:54

This is so clunky

app/jobs/scheduled/clean_up_uploads.rb

32b8a2ccf


      
          .joins(<<~SQL)
            LEFT JOIN site_settings ss
            ON NULLIF(ss.value, '')::integer = uploads.id
            AND ss.data_type = #{SiteSettings::TypeSupervisor.types[:upload].to_i}
          SQL
          .joins("LEFT JOIN post_uploads pu ON pu.upload_id = uploads.id")
          .joins("LEFT JOIN users u ON u.uploaded_avatar_id = uploads.id")
          .joins("LEFT JOIN user_avatars ua ON ua.gravatar_upload_id = uploads.id OR ua.custom_upload_id = uploads.id")
          .joins("LEFT JOIN user_profiles up2 ON up2.profile_background = uploads.url OR up2.card_background = uploads.url")
          .joins("LEFT JOIN user_profiles up ON up.profile_background_upload_id = uploads.id OR up.card_background_upload_id = uploads.id")
          .joins("LEFT JOIN categories c ON c.uploaded_logo_id = uploads.id OR c.uploaded_background_id = uploads.id")
          .joins("LEFT JOIN custom_emojis ce ON ce.upload_id = uploads.id")
          .joins("LEFT JOIN theme_fields tf ON tf.upload_id = uploads.id")
          .joins("LEFT JOIN user_exports ue ON ue.upload_id = uploads.id")

For reviewables @eviltrout introduced a general mechanism where arbitrary objects could be linked to a reviewable.

Moving to a similar system for uploads would be like moving multiple mountains. It would be a nice mountain to move though cause this current system is pretty fragile.

Easiest workaround you have for now is to create a hidden site setting with a data_type for :upload. Then put it in the site settings table.

トピック		返信	表示
Cleaning up uploads and purging uploads from S3 Site Management reference , file-managment	2	1002	2024 年 12 月 24 日
Uploads not getting orphaned and purged Support	9	1492	2024 年 4 月 19 日
Is there a way to delete old/irrelevant uploads? Support	25	6254	2022 年 10 月 27 日
Post_uploads database table Support	1	215	2023 年 11 月 24 日
How to make an image orphaned so that it gets removed? Support	22	2951	2024 年 6 月 8 日

Adding a stable way of adding whitelisted "orphaned" uploads in a plugin

関連トピック