Adding support for stl models to github_blob engine

开发
1

I’ve modified the onebox github_blob engine to display the stl model file using github’s render url.

This is my first attempt at modifying onebox. Feedback is welcome.

I’m testing with “Mendel90/dibond/stls/x_motor_bracket.stl at master · nophead/Mendel90 · GitHub” but that repo is full of stl files that you can test with.

1 个赞
2

Looks like the automated tests that are failing for onebox are failing since the version bump.

3

@zogstrip @maja Can someone take a look at travis-ci and tell me why the tests are failing?
https://travis-ci.org/discourse/onebox/jobs/515606903

4

Gemfile.lock wasn’t updated with a new version after version bump, it should work now: update Gemfile.lock · discourse/onebox@d0f99c5 · GitHub

3 个赞
5

Thanks. Since my pull request is still showing a travis-ci failure, should I close it and recreate it?

6

Thank you! I was just wishing for this today because I wanted to display as a model:

https://github.com/johnsonm/lathe-tool-models/blob/master/square-tool.stl

…and a visual model would be more compelling than the textual content! :smiling_face:

7

The current version does nothing to set the size of the iframe window so the rendered model is fairly small.

Screenshot%20from%202019-04-08%2015-31-39
Screenshot from 2019-04-08 15-31-39.png913×412 18.3 KB
I initially thought that was ok since clicking on the link will take you to a page with a larger version of the rendered model but now I’m wondering if the embedded display should be a little larger.

Looking at the youtube plugin, it uses 480x360 which seems like a good size.

Screenshot%20from%202019-04-12%2010-17-33
Screenshot from 2019-04-12 10-17-33.png764×591 28.8 KB

It makes me wonder if I should set the default size to 480x360 or leave it as it is.

4 个赞
8

As someone who creates models and intends to use this feature, I think that the 480x360 is a more meaningful aspect ratio for interactive content like this.

9

I closed the PR and created a new one.

3 个赞