Admin email screened and rejected when replying to thread by email

ANoetinger · 11월 21, 2019, 9:37오전

For a few weeks now, we face issues when one of our admins replies directly by email to a thread.
All his replies are not appearing on the thread. For each, we get this message Email::Receiver::ScreenedEmailError. The email he uses is the one he has on record for his profile.

codinghorror · 11월 21, 2019, 2:58오후

Has this persons email been added to the screened emails (blocked emails) list? Check in admin, logs.

ANoetinger · 11월 21, 2019, 3:27오후

The persons email is not part of screened email list.

arnauvp · 2월 25, 2020, 3:11오후

@codinghorror we found out what was happening! The screened email method is not finding matches by equality, but with some distance algorithm (levenshtein). A user was blocked and it was only 2 characters different from the admin email, giving a false positive.

github.com/discourse/discourse

app/models/screened_email.rb

514c22e64


      
          def self.block(email, opts = {})
            find_by_email(Email.downcase(email)) || create(opts.slice(:action_type, :ip_address).merge(email: email))
          end
          
          def self.should_block?(email)
            screened_emails = ScreenedEmail.order(created_at: :desc).limit(100)
          
            distances = {}
            screened_emails.each { |se| distances[se.email] = levenshtein(se.email.downcase, email.downcase) }
          
            max_distance = SiteSetting.levenshtein_distance_spammer_emails
            screened_email = screened_emails.select { |se| distances[se.email] <= max_distance }
              .sort   { |se| distances[se.email] }
              .first
          
            screened_email.record_match! if screened_email
          
            screened_email.try(:action_type) == actions[:block]
          end
          
          def self.levenshtein(first, second)

I know there is a setting for that distance, but I wonder if moderators/admins shouldn’t be protected or even if strict matching should be the default.

Thanks for creating such an awesome tool BTW.

codinghorror · 2월 26, 2020, 12:57오전

Wow that is a first! I wonder if we should exempt staff from this check but it has to be sooo rare.

supermathie · 2월 26, 2020, 2:08오전

Should we allow established users who already have accounts to bypass this check regardless?

글		댓글	조회수
Are screened email partially matched at signup? Support	2	562	5월 17, 2019
Email is not allowed Support	4	3859	8월 21, 2018
Reply key / email address check not working? (replies by email) Support	16	1885	11월 14, 2019
Troubleshoot reply by email Self-Hosting email , how-to	0	26995	4월 4, 2016
How to unblock an applicant Support	1	479	2월 18, 2022

Admin email screened and rejected when replying to thread by email

Related topics