Admins can't remove themselves from PMs

Contribute Bug

AI 生成的摘要

Admins can’t remove themselves from PMs

A bug has been reported where admins are unable to remove themselves from private messages (PMs). The issue is described by cpradio through a series of reproduction steps and screenshots. Despite the admin being shown as removed from the PM, they remain listed as a recipient after refreshing the page.

The expected behavior is for admins to be able to remove themselves from PMs to avoid notifications and make it clear to users they are no longer part of the discussion. cpradio notes that moderators can successfully remove admins from PMs, and admins can remove other admins, but not themselves.

codinghorror suggested that sam review the issue, who confirmed it as a bug. The issue has since been fixed with a commit to the Discourse GitHub repository: https://github.com/discourse/discourse/commit/4b449914b822bb35bce6f1c41625a6320c0d326a.

1

Reproduction Steps:

  1. testuser2 (not staff), messages testuser5 (also not staff)
  2. testuser2 invites admin (an admin) to PM
  3. admin replies he has nothing he can contribute and then clicks the next to admin to remove himself
  4. Message denoting admin removed admin is shown in PM thread (recipient list removes admin too)
    Pasted image792×506 20.8 KB
  5. Refresh the page, admin is still listed as a recipient,
    Pasted image783×492 24.1 KB

Expected:
Admins should be able to remove themselves from a topic to avoid notifications and make it clear to the users they are not on it.

It is understood the admin can review that PM regardless, but to end users, it makes it clear that the admin is not apart of the active discussion anymore.

Side Note:
If any of the recipients is a moderator. They can successfully remove the admin from the PM.
Other admins can remove other admins too. It is just an admin can’t remove themselves from a PM.

Tested on Latest, ping @ralphm

6 个赞
2

Maybe @sam should have a look at this?

3

Confirmed, this is a bug.

4 个赞
4

Fixed per:

https://github.com/discourse/discourse/commit/4b449914b822bb35bce6f1c41625a6320c0d326a

4 个赞