مكون البطل المتقدم

Looks like you used the versatile banner as an example. And there is nothing wrong with that in general, but you, for example, kept all the translated locale files. While you customized the English ones by changing, for example, “banner” to “hero banner”, you didn’t do the same on the translated files. Don’t get me wrong, I don’t expect you to translate your component, but it’s important to remove outdated translations. If there is no German translation, I will see the English text as you wrote it. But if you keep the translation unchanged, I will see outdated German texts. Usually, outdated texts are more confusing than English texts.

If I were you, I’d delete all those translation files and keep only en.yml.

You also still use the link to the versatile banner as the about_url in the about.json, and the license_url doesn’t link to your repo.

4 إعجابات