Agree -> Keep Post flag option not working

Contribute Bug

AI-generated summary

The “Agree → Keep Post” flag option is not working as expected. Lilly_S reported that the flag continues to appear in the unhandled flag list after agreeing to keep the post. codinghorror initially thought it was working correctly, but after Lilly_S provided repro steps, codinghorror was able to reproduce the issue and suspected a regression. sam confirmed it was a server-side bug and later fixed it in this commit.

1

Hi,

It seems that the flag option for “Agree → Keep Post” isn’t working. It removes the flag from /flags/active until you refresh or navigate away, at which point it will re-appear.

Any thoughts?

Thanks,
Lilly

2

How is that not working? You agreed with the flag, and the post was kept.

The flag has now been handled and will no longer appear in your unhandled flag list.

3

The flag continues to appear in the unhandled flag list.

Repro steps:

  1. Navigate to /flags/active
  2. Click “Agree…” then click “Keep Post”
  3. Navigate away from the page
  4. Navigate back to /flags/active

The flag that you just agreed to, using the Keep Post option, is still there waiting to be resolved.

1 Like
4

Oh dear definitely I can repro on try. Something regressed here @sam. Any recent changes in this area @eviltrout?

5

Will have a look this morning, client side seems fine, this is a bug server side.

3 Likes
7

Fixed per:

https://github.com/discourse/discourse/commit/6797395bd09ade259f03776749ec87ebe590a0c4

This area was very thinly tested, this fix regressed the behavior

https://github.com/discourse/discourse/commit/c12a9279f6182df2ca72d200c324d97b0ea6c220

7 Likes
8

This topic was automatically closed after 31 hours. New replies are no longer allowed.