编辑历史中显示了一个 onebox

Moin · 2026 年9 月 11 日 09:41

编辑历史中的 onebox 组件占用的空间对我来说有点太大了。

帖子链接

zogstrip · 2026 年9 月 12 日 15:30

感谢你的报告 @Moin

diffing 确实很难但希望这个 PR 合并后情况会好一些

github.com/discourse/discourse

FIX: Don't wrap whitespace between tags in revision diffs (#43604)

main ← fix-revision-diff-whitespace-tokens

merged 11:46PM - 12 Sep 26 UTC

ZogStriP

+77 -53

Previously, `DiscourseDiff` wrapped every added text token in `<ins>`, including… the formatting whitespace between tags. Inside a GitHub onebox, whose body is a CSS grid with `display: contents` rows, those extra elements became grid items and displaced the title into the 2.5em icon column, where it wrapped one character per line. This change appends whitespace-only text nodes to the preceding tag token so they can never become elements. It also fixes three things found alongside it: - closing tags were given a class, emitting `</h4 class="diff-ins">` - `class=` was matched inside attribute values, so `[text](url "class=foo")` raised `NoMethodError` and returned a 500 from the revisions endpoint - the raw view tinted the whole cell even when only some words changed, hiding the word-level markers underneath, and quote backgrounds hid the highlight on an inserted or removed quote Reported in https://meta.discourse.org/t/appearance-of-a-onebox-in-the-edit-history/412207

zogstrip · 2026 年9 月 14 日 08:13

现在 diff 看起来是这样的

话题		回复	浏览量
Inconsistent internal onebox spacing UX	7	1283	2022 年5 月 13 日
Width of edit history with formated code on moblie UX fixed , revisions	3	556	2023 年10 月 2 日
HTML diff view is a bit broken Feature	6	1999	2025 年6 月 15 日
GitHub onebox wrongly removes identation inside the curly braces Bug	4	1301	2019 年3 月 7 日
Twitter quote-tweets not shown in oneboxes Feature	15	2411	2019 年7 月 18 日

编辑历史中显示了一个 onebox

相关话题