ユーザー管理ページからカスタムグループにユーザーを追加しても「変更を承認」ボタンが消えない

zogstrip · 2026 年 2 月 7 日午後 11:14

Glimmerへの本格的なリファクタリングがより適していると思われる別のページですね

ひとまず、修正はこちらです

github.com/discourse/discourse

FIX: Custom groups save button not clearing on admin user page (#37625)

main ← fix/admin-user-custom-groups-save

opened 11:13PM - 07 Feb 26 UTC

ZogStriP

+96 -28

The approve/reject buttons for custom group changes on the admin user page would… remain visible after saving, even though the changes were persisted successfully. Removing a group also failed to update the UI. Three issues in the reactivity chain caused this: 1. The `@filter` computed macros (classic Ember) on the AdminUser model did not react to `@trackedArray` mutations. Replaced `customGroups` and `automaticGroups` with native getters so they participate in Glimmer autotracking. 2. The controller's `groupAdded()` and `groupRemoved()` wrappers did not return their promise chains, so `await` in `saveCustomGroups()` resolved immediately before the API calls completed and before the groups array was updated. 3. The controller's `customGroupIds`, `customGroupsDirty`, and `automaticGroups` used `@discourseComputed` which could not track changes from native getters on the model. Converted these to native getters and made `customGroupIdsBuffer` `@tracked`. Additionally, `saveCustomGroups()` now awaits each operation sequentially and calls `resetCustomGroups()` on completion to sync the buffer with the updated group list, clearing the dirty state. Note: only the properties involved in the groups reactivity chain were converted to modern Glimmer patterns. The rest of the controller and model still use classic Ember (`@discourseComputed`, `this.set`, etc.) and can be modernized separately. Ref - https://meta.discourse.org/t/395210

トピック		返信	表示
Custom groups field is blank Bug	4	1162	2015 年 4 月 16 日
Users custom group membership not shown Bug groups	2	1116	2015 年 4 月 16 日
Adding owners/members UX is inconsistent and misleading UX	26	3029	2018 年 4 月 20 日
Unable to save changes to a Group Bug	6	624	2018 年 4 月 12 日
Improved Group Members Management Feature rfc , spec	31	11180	2016 年 1 月 7 日

ユーザー管理ページからカスタムグループにユーザーを追加しても「変更を承認」ボタンが消えない

関連トピック