Approve suspect user

AI-generated summary

A bug was reported where suspect users—those with minimal activity but customized bios—were being sent to the review queue due to the approve suspect users setting, but no approve button was available, only a delete option. Disabling the setting didn’t remove existing suspect users from the queue. tomtjes confirmed the must_approve_users setting was still enabled, which Roman investigated. Roman identified the issue and pushed a fix here, including a migration to auto-approve previously stuck users. pacharanero confirmed the issue on version 2.5.0beta2. tomtjes thanked Roman for the quick resolution. Users are advised to disable approve_suspect_users temporarily until the fix is deployed.

There is a suspect user in my review queue, apparently because of this recently added feature:

Discourse 2.4.0.beta11 Release Notes

Suspect users sent to review queue

Suspect users - those who have viewed less than one post and one topic but have customized their bio - are now sent to the review queue. Such users have a high likelihood of being spammers, as most users browse the site before taking time to fill out their bio.

Enable the approve suspect users setting to try it out!

However, there is no button to approve the user. Only a Delete User button. Safe Mode didn’t help either. Next, I switched approve suspect users off, but the user is still in my review queue.

8 Likes

One for you @Roman

9 Likes

I can confirm this is also happening for us, on 2.5.0beta2, exactly as the OP describes.

6 Likes

Thanks for reporting, @tomtjes!

This will only stop suspect users from being enqueued in the review queue.


Can you check if the must_approve_users setting was set to true at some point for your site? I’d like to validate that it was caused by this before working on a fix.

You can check this under /admin/logs/staff_action_logs using the “change site setting” filter.

6 Likes

Yes, that is still set to true.

4 Likes

I’m working on a fix right now. Please disable the approve_suspect_users setting in the meantime.

5 Likes

I pushed the fix:

https://review.discourse.org/t/fix-when-must-approve-users-is-enabled-we-dont-want-to-send-suspect-users-to-the-review-queue-only-non-approved-users-should-be-sent-provide-a-migration-to-auto-approve-every-problematic-review-item-9179/9759/3

I included a migration that will approve users who were already approved.

10 Likes

Awesome, thank you for the quick fix!

5 Likes