ה-Back-end מאפשר למודרטורים להשתמש במיזוג/העברת פוסטים להודעה פרטית, אך ה-Front-end לא

Hooksmith · 4 באוקטובר,‏ 2020,‏ 9:17pm

This functionality shows up when you are administrator, but not for moderators:

The front-end code for this is here:

app/assets/javascripts/discourse/app/controllers/move-to-topic.js

52672b9ea


      
          @discourseComputed("canSplitTopic")
          canSplitToPM(canSplitTopic) {
            return canSplitTopic && this.currentUser && this.currentUser.admin;
          },

Note the “this.currentUser.admin”.

However, the back-end allows for moderators (all staff) to perform this action just fine:

github.com/discourse/discourse

app/controllers/topics_controller.rb

5cf411c3a


      
          raise Discourse::InvalidAccess if params[:archetype] == "private_message" && !guardian.is_staff?
          
          topic = Topic.find_by(id: topic_id)
          guardian.ensure_can_move_posts!(topic)
          
          destination_topic = Topic.find_by(id: destination_topic_id)
          guardian.ensure_can_create_post_on_topic!(destination_topic)

github.com/discourse/discourse

app/controllers/topics_controller.rb

5cf411c3a


      
          raise Discourse::InvalidAccess if params[:archetype] == "private_message" && !guardian.is_staff?
          
          topic = Topic.with_deleted.find_by(id: topic_id)
          guardian.ensure_can_move_posts!(topic)

github.com/discourse/discourse

lib/guardian/topic_guardian.rb

9f73e8779


      
          def can_perform_action_available_to_group_moderators?(topic)
            return false if anonymous? || topic.nil?
            return true if is_staff?
            return true if @user.has_trust_level?(TrustLevel[4])
          
            is_category_group_moderator?(topic.category)
          end
          alias :can_archive_topic? :can_perform_action_available_to_group_moderators?
          alias :can_close_topic? :can_perform_action_available_to_group_moderators?
          alias :can_split_merge_topic? :can_perform_action_available_to_group_moderators?
          alias :can_edit_staff_notes? :can_perform_action_available_to_group_moderators?
          
          def can_move_posts?(topic)
            return false if is_silenced?
            can_perform_action_available_to_group_moderators?(topic)
          end

I think the front-end code should be adjusted:

@discourseComputed("canSplitTopic")
canSplitToPM(canSplitTopic) {
-  return canSplitTopic && this.currentUser && this.currentUser.admin;
+  return canSplitTopic && this.currentUser && this.currentUser.staff;
},

If you agree with this being a bug I’d be happy to make a PR to fix it. Our moderation team would have need of this fix.

codinghorror · 4 באוקטובר,‏ 2020,‏ 11:02pm

I’m not sure but it seems plausible. What do you think @techAPJ?

techAPJ · 5 באוקטובר,‏ 2020,‏ 7:16am

The decision to not show “move to new PM” option for moderators was made explicitly in:

This is because the moderators do not have permission to see PMs and the relevant code will fail at:

github.com/discourse/discourse

app/models/post_mover.rb

310952fd6


      
            topic
          end
          
          private
          
          def update_topic_excerpt(topic)
            topic.update_excerpt(topic.first_post.excerpt_for_topic)
          end
          
          def move_posts_to(topic)
            Guardian.new(user).ensure_can_see! topic
            @destination_topic = topic
          
            moving_all_posts = (@original_topic.posts.pluck(:id).sort == @post_ids.sort)
          
            create_temp_table
            delete_invalid_post_timings
            move_each_post
            notify_users_that_posts_have_moved
            update_statistics
            update_user_actions

Hooksmith · 5 באוקטובר,‏ 2020,‏ 12:32pm

Would it be feasible if a code change is made so that the acting moderator/administrator is added as a recipient on the newly created topic (private message) so that they can see the new topic once it is created? (and would this be a change you folks are interested in receiving?)

techAPJ · 6 באוקטובר,‏ 2020,‏ 2:51am

I’ll look into the possibility of adding acting moderator as PM recipient and subsequently enabling the feature “move posts to a new PM” for moderators.

Hooksmith · 6 באוקטובר,‏ 2020,‏ 11:18am

Great! In case this ends up in backlog / deprioritized and is PR welcome, please let me know and I could help with implementation.

techAPJ · 8 באוקטובר,‏ 2020,‏ 5:50am

It might take a bit for me to get to this. PR is 100% welcome here!

נושא		תגובות	צפיות
How can I move posts to a new message? Support	7	1091	9 באוקטובר,‏ 2023
Convert a private message to public topic or vice versa Feature feedback	15	7011	21 באוקטובר,‏ 2016
Moderators can see the move posts to PM button but can't use it Bug	4	635	18 בפברואר,‏ 2019
Splitting topic into a new message for moderation Community	8	950	8 במאי,‏ 2022
Move posts to private conversation Feature	21	3233	13 בינואר,‏ 2022

ה-Back-end מאפשר למודרטורים להשתמש במיזוג/העברת פוסטים להודעה פרטית, אך ה-Front-end לא

נושאים קשורים