Badge Capitalisation (And Punctuation) Inconsistencies

Contribute Site feedback

AI-generated summary

A discussion on inconsistencies in badge capitalization and punctuation on the Badges page has been initiated by khenmu. The issues include:

  • Inconsistent capitalization in badge names and descriptions
  • Descriptions starting with lowercase letters
  • Full stops at the end of some descriptions
  • Typos in descriptions

The topic was moved to ux, but jomaxro encouraged khenmu to submit a PR for the changes. JammyDodger took care of the issues and updated the badges.

However, khenmu discovered more issues, including duplicate badges with the same name and description but different numbers of earners. JammyDodger investigated further and found that the issue was with the generation process. A PR (https://github.com/discourse/discourse-github/pull/69) was created to address the problem.

1

Being an insomniac, I noticed the following inconsistencies on the Badges page;

Capitalisation

  • [Development] Great contributor’s name isn’t capitalised in the usual way.
  • [Development] Amazing contributor’s name isn’t capitalised in the usual way.
  • [Development] Amazing committer’s name isn’t capitalised in the usual way.
  • [Development] Contributor’s description begins with a lower case letter.
  • [Development] Great contributor’s description begins with a lower case letter.
  • [Development] Amazing contributor’s description begins with a lower case letter.
  • [Development] Amazing committer’s description begins with a lower case letter.

Punctuation

  • [Community] Scribe’s description has a full stop at the end.
  • [Development] Plugin Author’s description has a full stop at the end.
  • [Development] Theme Author’s description has a full stop at the end.

Spelling

  • [Development] Great contributor’s description contains a typo: “contributed 25 accepted pull request” (“request” should be plural).
  • [Development] Amazing contributor’s description contains a typo: “contributed 250 accepted pull request” (“request” should be plural).
5 Likes
2

Nothing wrong with nitpicking.

I did move this over to Contribute > UX though, definitely stretching the definition of Contribute > Bug a bit too far.

3 Likes
3

Fair ‘nuff. :smiley:

In the past I’ve encountered teams who treated text-related issues as “text bugs”, just for the sake of having everything needing changed all in one place. Still learning how you folks do things.

3 Likes
4

It’s all good! No harm in a quick category change.

If you’re feeling up to it, feel free to submit a PR with the necessary changes for review. Discourse is open source after all. If not, I imagine a member of the team, or another contributor will handle it at some point.

3 Likes
5

I think these are all our custom ones? I’ll have a look today. :+1:

Update: And they’ve been amended. :partying_face: Thanks for the report. :slightly_smiling_face:

(Barring a few anomalies that I will continue to work-through… :slight_smile:)

6 Likes
7

Hi, me again.

There are two badges with the same name and description. Paradoxically, they have been earned by a different number of users. It’s kinda weird! :sweat_smile:

image
image2235×1021 184 KB

Also, the bottom two have names that aren’t properly capitalised, descriptions which don’t begin with capital letters, and either they or the other Amazing Contributor are in the wrong section.

2 Likes
8

Yup. :+1: I believe it’s the way they’re generated. I’m looking into it. :slightly_smiling_face:

I had to get a little help on this one, but it should all be smoothed out now with this:

https://github.com/discourse/discourse-github/pull/69

1 Like