Bookmark clock icon broken after changing icon set

AI-generated summary

The issue concerns a broken bookmark clock icon in Discourse when switching from FontAwesome Pro Solid to Light icons, as the fal-discourse-bookmark-clock icon is missing. awesomerobot addressed this by reverting to the default icon, but this fix caused other icons like ellipsis-h and pencil-alt to disappear. RGJ reported the issue, noting that even with the fix applied, the icons are missing despite clearing the cache. awesomerobot suggested potential compatibility issues or missing icon renames, while j.jaffeux questioned whether the thread should remain open. The problem persists, with no clear resolution yet jrgong confirming it’s still present in 3.3.

When changing the FontAwesome Pro icons from Solid to Light, the icon that shows when you set a bookmark with a reminder time on a post no longer shows up.

It looks like the plugin changes <use xlink:href="#discourse-bookmark-clock"></use> to <use xlink:href="#fal-discourse-bookmark-clock"></use>, but this just appears blank because there is no fal version of this icon.

3 Likes

I have the exact same issue, on 2.9beta9 tests-passed

1 Like

Digging out this one as it’s still an issue on 3.2

1 Like

We still have this issue on 3.3 :smiley:

1 Like

I’ve just made an update to the plugin that will use our default bookmark clock icon so it will no longer appear blank.

Unfortunately since this is a custom icon we built for Discourse based on the open source set of fontawesome icons, I don’t think we can actually build and distribute a version of this icon that uses the pro style as it would violate the fontawesome pro licensing.

2 Likes

This topic was automatically closed 6 days after the last reply. New replies are no longer allowed.

I see the icon has been re-added in eb39fb6 but even when I checkout your fix and not any newer commits on 3.3.1 stable, it brings back the bookmark clock icon but unfortunately it makes the more button (d-icon-ellipsis-h) and edit button (d-icon-pencil-alt) disappear… do you have any idea what is going on? I tried clearing the icon cache but to no avail.

3 Likes

i wonder if related - Some icons not showing up after upgrade :thinking:

1 Like

I think according to .discourse-compatibility you’re pinned to an older version of the plugin, right? maybe a compatibility issue with older versions of Discourse? discourse-fontawesome-pro/.discourse-compatibility at eb39fb6bdc567b77a54ce50366b804c9971467e2 · discourse/discourse-fontawesome-pro · GitHub

I wouldn’t expect removing a reference to a single icon to break unrelated icons :thinking:

1 Like

Good catch, but no, I ignored that :sunglasses:

2 Likes

hmm and you don’t have the later commit that renamed the icons? DEV: update plugin to be compatible with core upgrade to fontawesome … · discourse/discourse-fontawesome-pro@eb39fb6 · GitHub

When you dig into the inspector, is the reference for the icon ellipsis or ellipsis-h?

3 Likes

So I am on cc8e59d7

image

1 Like

Im unclear if we need to keep this open @RGJ ?

Well… it’s still an unresolved issue… I have no idea what is causing this.

So it would be good if anyone who had something useful to add would be able to add it :wink:

1 Like